-
-
Notifications
You must be signed in to change notification settings - Fork 231
docs: output assetPrefix 'auto' documentation and typescript definition #6410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: output assetPrefix 'auto' documentation and typescript definition #6410
Conversation
…etPrefix type to include 'auto'
|
Davide Ghiotto seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the output.assetPrefix configuration option to explicitly allow the string literal value 'auto' in addition to regular strings. The change addresses a gap left from a previous update by adding the 'auto' option to both the TypeScript type definition and JSDoc documentation.
Key changes:
- Updated
assetPrefixtype fromstringtostring | 'auto' - Enhanced JSDoc to document the
'auto'behavior (relative path based on file location) - Reordered import statements (Node.js types moved after
@rspack/coreimports)
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!

Summary
Modify output.assetPrefix type to include 'auto' as an option in the jsdocs and typescript types
Related Links
Fixing what was left missing in this change
Checklist