Skip to content

Conversation

@davide97g
Copy link
Contributor

Summary

Modify output.assetPrefix type to include 'auto' as an option in the jsdocs and typescript types

Related Links

Fixing what was left missing in this change

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings October 22, 2025 15:27
@CLAassistant
Copy link

CLAassistant commented Oct 22, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ chenjiahan
❌ Davide Ghiotto


Davide Ghiotto seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@netlify
Copy link

netlify bot commented Oct 22, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 00cac78
🔍 Latest deploy log https://app.netlify.com/projects/rsbuild/deploys/68f990a88139e1000809fa24
😎 Deploy Preview https://deploy-preview-6410--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 67 (🟢 up 13 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the output.assetPrefix configuration option to explicitly allow the string literal value 'auto' in addition to regular strings. The change addresses a gap left from a previous update by adding the 'auto' option to both the TypeScript type definition and JSDoc documentation.

Key changes:

  • Updated assetPrefix type from string to string | 'auto'
  • Enhanced JSDoc to document the 'auto' behavior (relative path based on file location)
  • Reordered import statements (Node.js types moved after @rspack/core imports)

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@davide97g davide97g changed the title fix(types): reorder and update type imports in config.ts; enhance ass… docs: output assetPrefix 'auto' documentation and typescript definition Oct 22, 2025
chenjiahan
chenjiahan previously approved these changes Oct 23, 2025
Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@chenjiahan chenjiahan enabled auto-merge (squash) October 23, 2025 02:15
@chenjiahan chenjiahan merged commit fbb65f1 into web-infra-dev:main Oct 23, 2025
10 of 11 checks passed
@davide97g davide97g deleted the fix/output-asset-prefix-docs branch October 24, 2025 14:30
@chenjiahan chenjiahan mentioned this pull request Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants