[Bug]: if I don’t set minify to true, the code after building is not compressed

[wjw-gavin]

Version

"@rslib/core": "^0.2.2"

Details

The default setting in the docs is true, but I found that if I don’t set minify: true, the code after building is not compressed. Please check this.

Reproduce link

https://github.com/web-infra-dev/rslib

Reproduce Steps

pnpm build

[9aoy]

I think this is an issue with the rslib documentation, the minify default value of rslib is different from that of rsbuild.
@Timeless0911 hi, it looks like there are some rslib and rsbuild configurations that have different default values, but it's not pointed out in the rslib documentation.

[wjw-gavin]

I think this is an issue with the rslib documentation, the minify default value of rslib is different from that of rsbuild. @Timeless0911 hi, it looks like there are some rslib and rsbuild configurations that have different default values, but it's not pointed out in the rslib documentation.

Sorry, I didn't pay attention to the repository. I opened github from the rslib document. I don't know why it jumped to rsbuild, so I asked the question directly.

[Timeless0911]

The default setting in the docs is true

@wjw-gavin where is this from?

[wjw-gavin]

The default setting in the docs is true

@wjw-gavin where is this from?

https://rsbuild.dev/config/output/minify

[wjw-gavin]

The configuration I found here, and then I jumped to the documentation of rsbuild. Then I found that the documentation was inconsistent with the actual results, so I clicked on the rsbuild repository address and asked a question.

[Timeless0911]

In library development, minify is not a necessary option, which is very detrimental to the readability of the output.

The default value of Rslib is somewhere different with Rsbuild, we will declare it in Rslib documentation.

Thank you for your wise eyes to discover the shortcomings of Rslib documentation now.

[wjw-gavin]

In library development, minify is not a necessary option, which is very detrimental to the readability of the output.

The default value of Rslib is somewhere different with Rsbuild, we will declare it in Rslib documentation.

Thank you for your wise eyes to discover the shortcomings of Rslib documentation now.

OK, The jump between the two documents makes me a little dizzy. 😂

[Timeless0911]

I will improve that to introduce the difference between Rsbuild next week.