Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ForkTSCheckerWebpackPlugin support #2602

Closed
Tracked by #2592
hardfist opened this issue Apr 4, 2023 · 4 comments
Closed
Tracked by #2592

ForkTSCheckerWebpackPlugin support #2602

hardfist opened this issue Apr 4, 2023 · 4 comments
Labels
contrib: hard good first issue Good for newcomers team The issue/pr is created by the member of Rspack.

Comments

@hardfist
Copy link
Contributor

hardfist commented Apr 4, 2023 •
edited

fork-ts-checker-webpack-plugin is widely used, we need to support it
@hardfist hardfist mentioned this issue Apr 4, 2023
Open
@hardfist hardfist changed the title ForkTSCheckerWebpackPlugin ForkTSCheckerWebpackPlugin support Apr 4, 2023
@github-actions github-actions bot added needs-triage team The issue/pr is created by the member of Rspack. labels Apr 4, 2023
@hyf0
Copy link
Collaborator

hyf0 commented Apr 6, 2023 •
edited

I'm not quite familiar with ForkTSCheckerWebpackPlugin.

So, my thoughts may be subjective. IMO, ForkTSCheckerWebpackPlugin is complicated, but the goal is actually quite simple: invoking type-check during compiling.

To achieve this goal, I'm more in favor of how https://github.com/fi3ework/vite-plugin-checker is implemented.

I'm talking to @fi3ework to see how we could use https://github.com/fi3ework/vite-plugin-checker in Rspack and Webpack.

@hyf0 hyf0 added good first issue Good for newcomers contrib: hard to be discussed Rspack team would discuss these issues per week and removed contribution welcome labels Apr 10, 2023
@jerrykingxyz jerrykingxyz removed the to be discussed Rspack team would discuss these issues per week label Apr 11, 2023
@ycjcl868
Copy link
Contributor

ycjcl868 commented May 15, 2023 •
edited

Watching

@hardfist
Copy link
Contributor Author

port https://github.com/fi3ework/vite-plugin-checker to rspack is feasible

@hardfist hardfist added good first issue Good for newcomers and removed good first issue Good for newcomers labels May 23, 2023
@hardfist
Copy link
Contributor Author

this is supported in 0.1.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contrib: hard good first issue Good for newcomers team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@hardfist @jerrykingxyz @ycjcl868 @KarthusLorin @hyf0