Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: 馃 bump napi retry #2784

Merged
merged 7 commits into from Apr 24, 2023
Merged

chore: 馃 bump napi retry #2784

merged 7 commits into from Apr 24, 2023

Conversation

IWANABETHATGUY
Copy link
Collaborator

@IWANABETHATGUY IWANABETHATGUY commented Apr 17, 2023 •
edited

Related issue (if exists)

Summary

  1. bump napi retry, I have tested locally, it should work fine.

馃 Generated by Copilot at 47d4f90

Update napi-rs dependencies and dev tools in node_binding crate and workspace. This improves the Node.js bindings compatibility and reliability, and fixes some CI issues caused by bitflags version mismatch.

Walkthrough

馃 Generated by Copilot at 47d4f90

  • Update napi-rs dependencies to the latest versions to fix bugs and improve compatibility (link, link, link, link, link, link)
  • Add bitflags to the ignore list in the check_rust_dependency.js script to avoid CI failures due to version mismatch (link)

@changeset-bot
Copy link

changeset-bot bot commented Apr 17, 2023 •
edited

鈿狅笍 No Changeset found

Latest commit: f839b5b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Apr 17, 2023
@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review April 18, 2023 11:40
@IWANABETHATGUY IWANABETHATGUY marked this pull request as draft April 24, 2023 03:40
h-a-n-a
h-a-n-a previously approved these changes Apr 24, 2023
View reviewed changes
@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review April 24, 2023 05:59
@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue Apr 24, 2023
Merged via the queue into main with commit 01f1241 Apr 24, 2023
10 checks passed
@IWANABETHATGUY IWANABETHATGUY deleted the chore/bump-napi3 branch April 24, 2023 06:02
siyou pushed a commit to siyou/rspack that referenced this pull request May 14, 2023
@IWANABETHATGUY @siyou
chore: 馃 bump napi retry (web-infra-dev#2784)
5e42e85 
* chore: 馃 bump napi retry

* chore: 馃 use main cargo.toml

* chore: minimum change

* fix: 馃悰 syntax error

* chore: 馃 update lock

* fix: 馃悰 check rs

* chore: 馃 lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-a-n-a h-a-n-a h-a-n-a approved these changes

@hardfist hardfist Awaiting requested review from hardfist

@Boshen Boshen Awaiting requested review from Boshen

@hyf0 hyf0 Awaiting requested review from hyf0

Assignees
No one assigned
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@IWANABETHATGUY @h-a-n-a