Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use zx to replace xtask #2840

Merged
merged 3 commits into from Apr 20, 2023
Merged

chore: use zx to replace xtask #2840

merged 3 commits into from Apr 20, 2023

Conversation

hyf0
Copy link
Collaborator

@hyf0 hyf0 commented Apr 20, 2023

Related issue (if exists)

Summary

馃 Generated by Copilot at 5abf645

This pull request removes the xtask crate and replaces its functionality with node scripts for benchmarking the rspack crate with different versions of the three.js library. It also updates the code owners file, the TypeScript config file, and the cargo config file to reflect the changes. Additionally, it adds a utility script to check the workspace root and a typecheck script to verify the scripts folder.

Walkthrough

馃 Generated by Copilot at 5abf645

@changeset-bot
Copy link

changeset-bot bot commented Apr 20, 2023

鈿狅笍 No Changeset found

Latest commit: 70a3f84

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Apr 20, 2023
@hyf0
Copy link
Collaborator Author

hyf0 commented Apr 20, 2023

@hyf0
Copy link
Collaborator Author

hyf0 commented Apr 20, 2023

@github-actions
Copy link
Contributor

Benchmark Results

group                                                 baseline                                 pr
-----                                                 --------                                 --
criterion_benchmark/ten_copy_of_threejs               861.29      2.4卤0.07s        ? ?/sec     1.00      2.8卤0.83ms        ? ?/sec
high_cost_benchmark/ten_copy_of_threejs_production    2850.73      8.5卤0.16s        ? ?/sec    1.00      3.0卤0.80ms        ? ?/sec

@hyf0
Copy link
Collaborator Author

hyf0 commented Apr 20, 2023

@IWANABETHATGUY The benchmark CI runs successfully. You are free to review this PR.

@IWANABETHATGUY
Copy link
Collaborator

@IWANABETHATGUY The benchmark CI runs successfully. You are free to review this PR.

Are you sure ? baseline now is 861 times slower than current branch

@hyf0
Copy link
Collaborator Author

hyf0 commented Apr 20, 2023

!bench

@github-actions
Copy link
Contributor

Benchmark Results

group                                                 baseline                               pr
-----                                                 --------                               --
criterion_benchmark/ten_copy_of_threejs               1.01       2.9卤0.10s        ? ?/sec    1.00       2.9卤0.12s        ? ?/sec
high_cost_benchmark/ten_copy_of_threejs_production    1.01       9.9卤0.18s        ? ?/sec    1.00       9.8卤0.32s        ? ?/sec

@hyf0 hyf0 added this pull request to the merge queue Apr 20, 2023
Merged via the queue into main with commit b4426ce Apr 20, 2023
9 checks passed
@hyf0 hyf0 deleted the chore_remove_xtask branch April 20, 2023 11:46
siyou pushed a commit to siyou/rspack that referenced this pull request May 14, 2023
* chore: use `zx` to replace xtask

* Fix script

* Fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants