From e39baff73464602fa019bbdc7bad0dcf4f899b78 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Philip=20J=C3=A4genstedt?= Date: Fri, 9 Aug 2024 12:01:17 +0200 Subject: [PATCH] Make the spec draft updater remove completed specs and work around nulls And update dist, which was overlooked. These changes together will allow the workflow to send PRs that pass the CI. --- .github/workflows/update_draft_features_weekly.yml | 2 ++ scripts/update-drafts.ts | 7 +++++++ 2 files changed, 9 insertions(+) diff --git a/.github/workflows/update_draft_features_weekly.yml b/.github/workflows/update_draft_features_weekly.yml index 29b7183df52..86ecf771802 100644 --- a/.github/workflows/update_draft_features_weekly.yml +++ b/.github/workflows/update_draft_features_weekly.yml @@ -16,7 +16,9 @@ jobs: node-version-file: .node-version cache: npm - run: npm ci + - run: rm features/draft/spec/*.yml features/draft/spec/*.dist - run: npm run update-drafts + - run: npm run dist - name: Commit changes run: | git config --local user.email "action@github.com" diff --git a/scripts/update-drafts.ts b/scripts/update-drafts.ts index 22ecc966415..f0dc55659c9 100644 --- a/scripts/update-drafts.ts +++ b/scripts/update-drafts.ts @@ -70,6 +70,13 @@ async function main() { continue; } + // A few null values remain in BCD. They are being removed in + // https://github.com/mdn/browser-compat-data/pull/23774. + // TODO: Remove this workaround when BCD is free or true/null values. + if (feature.id.startsWith("html.manifest.")) { + continue; + } + const spec_url = feature.data.__compat.spec_url; if (!spec_url) { continue;