From e8d87dfeede8f8cd56697eca0da3c5c013c263b8 Mon Sep 17 00:00:00 2001 From: Victor W Allen Date: Fri, 13 Sep 2024 10:32:59 -0700 Subject: [PATCH 1/5] Adds margin feature --- features/margin.yml | 15 +++++++++++++++ features/margin.yml.dist | 26 ++++++++++++++++++++++++++ 2 files changed, 41 insertions(+) create mode 100644 features/margin.yml create mode 100644 features/margin.yml.dist diff --git a/features/margin.yml b/features/margin.yml new file mode 100644 index 00000000000..f01608f835b --- /dev/null +++ b/features/margin.yml @@ -0,0 +1,15 @@ +name: margin +description: Margins define space surrounding a box. The `margin` CSS property provides a shorthand for `margin-top`, `margin-right`, `margin-bottom`, and `margin-left`. +spec: https://drafts.csswg.org/css-box-4/ +group: layout +compat_features: + - css.properties.margin + - css.properties.margin.auto + - css.properties.margin-bottom + - css.properties.margin-bottom.auto + - css.properties.margin-left + - css.properties.margin-left.auto + - css.properties.margin-right + - css.properties.margin-right.auto + - css.properties.margin-top + - css.properties.margin-top.auto diff --git a/features/margin.yml.dist b/features/margin.yml.dist new file mode 100644 index 00000000000..a732c0a5017 --- /dev/null +++ b/features/margin.yml.dist @@ -0,0 +1,26 @@ +# Generated from: margin.yml +# Do not edit this file by hand. Edit the source file instead! + +status: + baseline: high + baseline_low_date: 2015-07-29 + baseline_high_date: 2018-01-29 + support: + chrome: "1" + chrome_android: "18" + edge: "12" + firefox: "1" + firefox_android: "4" + safari: "1" + safari_ios: "1" +compat_features: + - css.properties.margin + - css.properties.margin-bottom + - css.properties.margin-bottom.auto + - css.properties.margin-left + - css.properties.margin-left.auto + - css.properties.margin-right + - css.properties.margin-right.auto + - css.properties.margin-top + - css.properties.margin-top.auto + - css.properties.margin.auto From 1a31548f63c8e0c55f774dbadb5ee8e2770c19c4 Mon Sep 17 00:00:00 2001 From: Victor W Allen Date: Fri, 13 Sep 2024 10:50:02 -0700 Subject: [PATCH 2/5] Adds padding feature --- features/padding.yml | 10 ++++++++++ features/padding.yml.dist | 21 +++++++++++++++++++++ 2 files changed, 31 insertions(+) create mode 100644 features/padding.yml create mode 100644 features/padding.yml.dist diff --git a/features/padding.yml b/features/padding.yml new file mode 100644 index 00000000000..c25870b404d --- /dev/null +++ b/features/padding.yml @@ -0,0 +1,10 @@ +name: padding +description: Padding defines space between the box edge and its contents. The `padding` CSS property provides a shorthand for `padding-top`, `padding-right`, `padding-bottom`, and `padding-left`. +spec: https://drafts.csswg.org/css-box-4/ +group: layout +compat_features: + - css.properties.padding + - css.properties.padding-bottom + - css.properties.padding-left + - css.properties.padding-right + - css.properties.padding-top diff --git a/features/padding.yml.dist b/features/padding.yml.dist new file mode 100644 index 00000000000..1486cfb840a --- /dev/null +++ b/features/padding.yml.dist @@ -0,0 +1,21 @@ +# Generated from: padding.yml +# Do not edit this file by hand. Edit the source file instead! + +status: + baseline: high + baseline_low_date: 2015-07-29 + baseline_high_date: 2018-01-29 + support: + chrome: "1" + chrome_android: "18" + edge: "12" + firefox: "1" + firefox_android: "4" + safari: "1" + safari_ios: "1" +compat_features: + - css.properties.padding + - css.properties.padding-bottom + - css.properties.padding-left + - css.properties.padding-right + - css.properties.padding-top From 5b5fc97e0ca96403ec4132d8e0e78557be029560 Mon Sep 17 00:00:00 2001 From: Victor W Allen Date: Fri, 13 Sep 2024 11:44:48 -0700 Subject: [PATCH 3/5] Addresses reviewer feedback --- features/margin.yml | 4 ++-- features/padding.yml | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/features/margin.yml b/features/margin.yml index f01608f835b..823c08e0781 100644 --- a/features/margin.yml +++ b/features/margin.yml @@ -1,6 +1,6 @@ name: margin -description: Margins define space surrounding a box. The `margin` CSS property provides a shorthand for `margin-top`, `margin-right`, `margin-bottom`, and `margin-left`. -spec: https://drafts.csswg.org/css-box-4/ +description: The `margin` CSS property sets space surrounding an element, and is a shorthand for `margin-top`, `margin-right`, `margin-bottom`, and `margin-left`. +spec: https://drafts.csswg.org/css-box-4/#margins group: layout compat_features: - css.properties.margin diff --git a/features/padding.yml b/features/padding.yml index c25870b404d..23ae64619c9 100644 --- a/features/padding.yml +++ b/features/padding.yml @@ -1,6 +1,6 @@ name: padding -description: Padding defines space between the box edge and its contents. The `padding` CSS property provides a shorthand for `padding-top`, `padding-right`, `padding-bottom`, and `padding-left`. -spec: https://drafts.csswg.org/css-box-4/ +description: The `padding` CSS property sets space between an element's edge and its contents. It provides a shorthand for `padding-top`, `padding-right`, `padding-bottom`, and `padding-left`. +spec: https://drafts.csswg.org/css-box-4/#paddings group: layout compat_features: - css.properties.padding From 73459e98353b562b09966e5dbd398fefe88bae92 Mon Sep 17 00:00:00 2001 From: Victor Allen Date: Mon, 30 Sep 2024 08:34:03 -0700 Subject: [PATCH 4/5] Apply suggestion to padding.yml description Co-authored-by: Patrick Brosset --- features/padding.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/features/padding.yml b/features/padding.yml index 23ae64619c9..dbcaf331562 100644 --- a/features/padding.yml +++ b/features/padding.yml @@ -1,5 +1,5 @@ name: padding -description: The `padding` CSS property sets space between an element's edge and its contents. It provides a shorthand for `padding-top`, `padding-right`, `padding-bottom`, and `padding-left`. +description: The `padding` CSS property sets space between an element's edge and its contents. It is a shorthand for `padding-top`, `padding-right`, `padding-bottom`, and `padding-left`. spec: https://drafts.csswg.org/css-box-4/#paddings group: layout compat_features: From ccf54eff0c064b2d93927185858df27a8ff8ab47 Mon Sep 17 00:00:00 2001 From: Victor Allen Date: Mon, 30 Sep 2024 08:35:19 -0700 Subject: [PATCH 5/5] Applies suggestion to margin.yml description Co-authored-by: Patrick Brosset --- features/margin.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/features/margin.yml b/features/margin.yml index 823c08e0781..9e59861826b 100644 --- a/features/margin.yml +++ b/features/margin.yml @@ -1,5 +1,5 @@ name: margin -description: The `margin` CSS property sets space surrounding an element, and is a shorthand for `margin-top`, `margin-right`, `margin-bottom`, and `margin-left`. +description: The `margin` CSS property sets space around an element. It is a shorthand for `margin-top`, `margin-right`, `margin-bottom`, and `margin-left`. spec: https://drafts.csswg.org/css-box-4/#margins group: layout compat_features: