From c532770638e149bc84e4d5cc5989190015341721 Mon Sep 17 00:00:00 2001 From: "Queen Vinyl Da.i'gyu-Kazotetsu" Date: Fri, 20 Sep 2024 05:41:04 -0700 Subject: [PATCH 1/7] Add features for VTTCue constructor and settings --- features/webvtt-cue-constructor.yml | 5 +++++ features/webvtt-cue-constructor.yml.dist | 17 +++++++++++++++++ features/webvtt-cue-settings.yml | 10 ++++++++++ features/webvtt-cue-settings.yml.dist | 22 ++++++++++++++++++++++ 4 files changed, 54 insertions(+) create mode 100644 features/webvtt-cue-constructor.yml create mode 100644 features/webvtt-cue-constructor.yml.dist create mode 100644 features/webvtt-cue-settings.yml create mode 100644 features/webvtt-cue-settings.yml.dist diff --git a/features/webvtt-cue-constructor.yml b/features/webvtt-cue-constructor.yml new file mode 100644 index 00000000000..039cede6747 --- /dev/null +++ b/features/webvtt-cue-constructor.yml @@ -0,0 +1,5 @@ +name: WebVTT Cue Constructor +description: The `VTTCue` API constructor can be used to create cues dynamically. +spec: https://w3c.github.io/webvtt/#dom-vttcue-vttcue +compat_features: + - api.VTTCue.VTTCue diff --git a/features/webvtt-cue-constructor.yml.dist b/features/webvtt-cue-constructor.yml.dist new file mode 100644 index 00000000000..431e7b41988 --- /dev/null +++ b/features/webvtt-cue-constructor.yml.dist @@ -0,0 +1,17 @@ +# Generated from: webvtt-cue-constructor.yml +# Do not edit this file by hand. Edit the source file instead! + +status: + baseline: high + baseline_low_date: 2020-01-15 + baseline_high_date: 2022-07-15 + support: + chrome: "33" + chrome_android: "33" + edge: "79" + firefox: "31" + firefox_android: "31" + safari: "8" + safari_ios: "8" +compat_features: + - api.VTTCue.VTTCue diff --git a/features/webvtt-cue-settings.yml b/features/webvtt-cue-settings.yml new file mode 100644 index 00000000000..2c9feb61454 --- /dev/null +++ b/features/webvtt-cue-settings.yml @@ -0,0 +1,10 @@ +name: WebVTT Cue Settings +description: The members of the `VTTCue` API can be used to update cues dynamically. +spec: https://w3c.github.io/webvtt/#the-vttcue-interface +compat_features: + - api.VTTCue.align + - api.VTTCue.line + - api.VTTCue.position + - api.VTTCue.size + - api.VTTCue.snapToLines + - api.VTTCue.vertical diff --git a/features/webvtt-cue-settings.yml.dist b/features/webvtt-cue-settings.yml.dist new file mode 100644 index 00000000000..5d6b29eb57b --- /dev/null +++ b/features/webvtt-cue-settings.yml.dist @@ -0,0 +1,22 @@ +# Generated from: webvtt-cue-settings.yml +# Do not edit this file by hand. Edit the source file instead! + +status: + baseline: high + baseline_low_date: 2020-01-15 + baseline_high_date: 2022-07-15 + support: + chrome: "23" + chrome_android: "25" + edge: "79" + firefox: "31" + firefox_android: "31" + safari: "6" + safari_ios: "8" +compat_features: + - api.VTTCue.align + - api.VTTCue.line + - api.VTTCue.position + - api.VTTCue.size + - api.VTTCue.snapToLines + - api.VTTCue.vertical From c38ecd2a61d80db2efe6e75ab877ff3b0b849a6d Mon Sep 17 00:00:00 2001 From: Florian Scholz Date: Fri, 22 Nov 2024 11:55:29 +0100 Subject: [PATCH 2/7] Delete features/webvtt-cue-constructor.yml --- features/webvtt-cue-constructor.yml | 5 ----- 1 file changed, 5 deletions(-) delete mode 100644 features/webvtt-cue-constructor.yml diff --git a/features/webvtt-cue-constructor.yml b/features/webvtt-cue-constructor.yml deleted file mode 100644 index 039cede6747..00000000000 --- a/features/webvtt-cue-constructor.yml +++ /dev/null @@ -1,5 +0,0 @@ -name: WebVTT Cue Constructor -description: The `VTTCue` API constructor can be used to create cues dynamically. -spec: https://w3c.github.io/webvtt/#dom-vttcue-vttcue -compat_features: - - api.VTTCue.VTTCue From e02256998afde0ee339c9a940feff92d389eac1d Mon Sep 17 00:00:00 2001 From: Florian Scholz Date: Fri, 22 Nov 2024 11:55:42 +0100 Subject: [PATCH 3/7] Delete features/webvtt-cue-constructor.yml.dist --- features/webvtt-cue-constructor.yml.dist | 17 ----------------- 1 file changed, 17 deletions(-) delete mode 100644 features/webvtt-cue-constructor.yml.dist diff --git a/features/webvtt-cue-constructor.yml.dist b/features/webvtt-cue-constructor.yml.dist deleted file mode 100644 index 431e7b41988..00000000000 --- a/features/webvtt-cue-constructor.yml.dist +++ /dev/null @@ -1,17 +0,0 @@ -# Generated from: webvtt-cue-constructor.yml -# Do not edit this file by hand. Edit the source file instead! - -status: - baseline: high - baseline_low_date: 2020-01-15 - baseline_high_date: 2022-07-15 - support: - chrome: "33" - chrome_android: "33" - edge: "79" - firefox: "31" - firefox_android: "31" - safari: "8" - safari_ios: "8" -compat_features: - - api.VTTCue.VTTCue From aa77e77414f6bbafcc02123e3030f004a10751ba Mon Sep 17 00:00:00 2001 From: Florian Scholz Date: Fri, 22 Nov 2024 15:53:46 +0100 Subject: [PATCH 4/7] Apply suggestions from code review Co-authored-by: Dietrich Ayala <50103+autonome@users.noreply.github.com> --- features/webvtt-cue-settings.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/features/webvtt-cue-settings.yml b/features/webvtt-cue-settings.yml index 2c9feb61454..fe5c53dbe30 100644 --- a/features/webvtt-cue-settings.yml +++ b/features/webvtt-cue-settings.yml @@ -1,5 +1,5 @@ -name: WebVTT Cue Settings -description: The members of the `VTTCue` API can be used to update cues dynamically. +name: WebVTT cue settings +description: The `VTTCue` API updates various aspects of cues dynamically, such as alignment, size and position. spec: https://w3c.github.io/webvtt/#the-vttcue-interface compat_features: - api.VTTCue.align From f5953c713fa4a7bba2aa250941b95e3ab7225b0f Mon Sep 17 00:00:00 2001 From: Florian Scholz Date: Tue, 26 Nov 2024 11:35:02 +0100 Subject: [PATCH 5/7] Add selectors --- features/webvtt-cue-settings.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/features/webvtt-cue-settings.yml b/features/webvtt-cue-settings.yml index fe5c53dbe30..f05df803ced 100644 --- a/features/webvtt-cue-settings.yml +++ b/features/webvtt-cue-settings.yml @@ -8,3 +8,5 @@ compat_features: - api.VTTCue.size - api.VTTCue.snapToLines - api.VTTCue.vertical + - css.selectors.cue + - css.selectors.cue.selector_argument From b07d1a183ef425f325b234127e34be0e49620ba3 Mon Sep 17 00:00:00 2001 From: Florian Scholz Date: Tue, 26 Nov 2024 11:39:07 +0100 Subject: [PATCH 6/7] Use compute_from --- features/webvtt-cue-settings.yml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/features/webvtt-cue-settings.yml b/features/webvtt-cue-settings.yml index f05df803ced..8551690b552 100644 --- a/features/webvtt-cue-settings.yml +++ b/features/webvtt-cue-settings.yml @@ -1,6 +1,14 @@ name: WebVTT cue settings description: The `VTTCue` API updates various aspects of cues dynamically, such as alignment, size and position. spec: https://w3c.github.io/webvtt/#the-vttcue-interface +status: + compute_from: + - api.VTTCue.align + - api.VTTCue.line + - api.VTTCue.position + - api.VTTCue.size + - api.VTTCue.snapToLines + - api.VTTCue.vertical compat_features: - api.VTTCue.align - api.VTTCue.line From 6b7ed9997d0b05d523ab6fee53af62c327aee908 Mon Sep 17 00:00:00 2001 From: Florian Scholz Date: Tue, 26 Nov 2024 11:39:29 +0100 Subject: [PATCH 7/7] refresh dist --- features/webvtt-cue-settings.yml.dist | 34 +++++++++++++++++++++++++++ 1 file changed, 34 insertions(+) diff --git a/features/webvtt-cue-settings.yml.dist b/features/webvtt-cue-settings.yml.dist index 5d6b29eb57b..1fe826fd712 100644 --- a/features/webvtt-cue-settings.yml.dist +++ b/features/webvtt-cue-settings.yml.dist @@ -14,9 +14,43 @@ status: safari: "6" safari_ios: "8" compat_features: + # ⬇️ Same status as overall feature ⬇️ + # baseline: high + # baseline_low_date: 2020-01-15 + # baseline_high_date: 2022-07-15 + # support: + # chrome: "23" + # chrome_android: "25" + # edge: "79" + # firefox: "31" + # firefox_android: "31" + # safari: "6" + # safari_ios: "8" - api.VTTCue.align - api.VTTCue.line - api.VTTCue.position - api.VTTCue.size - api.VTTCue.snapToLines - api.VTTCue.vertical + + # baseline: high + # baseline_low_date: 2020-01-15 + # baseline_high_date: 2022-07-15 + # support: + # chrome: "26" + # chrome_android: "26" + # edge: "79" + # firefox: "55" + # firefox_android: "55" + # safari: "7" + # safari_ios: "7" + - css.selectors.cue + + # baseline: false + # support: + # chrome: "26" + # chrome_android: "26" + # edge: "79" + # safari: "7" + # safari_ios: "7" + - css.selectors.cue.selector_argument