From 49099dfcbfa60bff8e49787658c40fe28a2f9e0c Mon Sep 17 00:00:00 2001 From: James Stuckey Weber Date: Tue, 17 Dec 2024 15:52:55 -0500 Subject: [PATCH 1/3] Add missing webvtt keys --- features/webvtt-cue-settings.yml | 1 + features/webvtt-cue-settings.yml.dist | 8 ++++++++ features/webvtt-regions.yml | 11 +++++++++++ features/webvtt-regions.yml.dist | 19 +++++++++++++++++-- 4 files changed, 37 insertions(+), 2 deletions(-) diff --git a/features/webvtt-cue-settings.yml b/features/webvtt-cue-settings.yml index 8551690b552..339c93975fb 100644 --- a/features/webvtt-cue-settings.yml +++ b/features/webvtt-cue-settings.yml @@ -13,6 +13,7 @@ compat_features: - api.VTTCue.align - api.VTTCue.line - api.VTTCue.position + - api.VTTCue.region - api.VTTCue.size - api.VTTCue.snapToLines - api.VTTCue.vertical diff --git a/features/webvtt-cue-settings.yml.dist b/features/webvtt-cue-settings.yml.dist index 1fe826fd712..9b78b24ff6b 100644 --- a/features/webvtt-cue-settings.yml.dist +++ b/features/webvtt-cue-settings.yml.dist @@ -54,3 +54,11 @@ compat_features: # safari: "7" # safari_ios: "7" - css.selectors.cue.selector_argument + + # baseline: false + # support: + # firefox: "59" + # firefox_android: "59" + # safari: "14.1" + # safari_ios: "14.5" + - api.VTTCue.region diff --git a/features/webvtt-regions.yml b/features/webvtt-regions.yml index 6540160b95d..00177fa1dbf 100644 --- a/features/webvtt-regions.yml +++ b/features/webvtt-regions.yml @@ -1,3 +1,14 @@ name: WebVTT regions description: WebVTT regions set the areas of the video where captions or subtitles should be rendered, such as placing roll-up captions used for live captions. spec: https://w3c.github.io/webvtt/#regions +compat_features: + - api.VTTRegion + - api.VTTRegion.VTTRegion + - api.VTTRegion.id + - api.VTTRegion.lines + - api.VTTRegion.regionAnchorX + - api.VTTRegion.regionAnchorY + - api.VTTRegion.scroll + - api.VTTRegion.viewportAnchorX + - api.VTTRegion.viewportAnchorY + - api.VTTRegion.width \ No newline at end of file diff --git a/features/webvtt-regions.yml.dist b/features/webvtt-regions.yml.dist index 9868f3f2f57..afef9af520d 100644 --- a/features/webvtt-regions.yml.dist +++ b/features/webvtt-regions.yml.dist @@ -6,9 +6,15 @@ status: support: firefox: "59" firefox_android: "59" - safari: "7" - safari_ios: "7" + safari: "12.1" + safari_ios: "12.2" compat_features: + # baseline: false + # support: + # firefox: "59" + # firefox_android: "59" + # safari: "7" + # safari_ios: "7" - api.VTTRegion - api.VTTRegion.VTTRegion - api.VTTRegion.id @@ -18,3 +24,12 @@ compat_features: - api.VTTRegion.viewportAnchorX - api.VTTRegion.viewportAnchorY - api.VTTRegion.width + + # ⬇️ Same status as overall feature ⬇️ + # baseline: false + # support: + # firefox: "59" + # firefox_android: "59" + # safari: "12.1" + # safari_ios: "12.2" + - api.VTTRegion.lines From c2cd6c5520f6b88b047619b1809360b346769634 Mon Sep 17 00:00:00 2001 From: James Stuckey Weber Date: Tue, 17 Dec 2024 15:54:07 -0500 Subject: [PATCH 2/3] Lint --- features/webvtt-regions.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/features/webvtt-regions.yml b/features/webvtt-regions.yml index 00177fa1dbf..cb59c18c73d 100644 --- a/features/webvtt-regions.yml +++ b/features/webvtt-regions.yml @@ -11,4 +11,4 @@ compat_features: - api.VTTRegion.scroll - api.VTTRegion.viewportAnchorX - api.VTTRegion.viewportAnchorY - - api.VTTRegion.width \ No newline at end of file + - api.VTTRegion.width From 8757476051107013f3cc6ac72400ecaecf50ba7d Mon Sep 17 00:00:00 2001 From: James Stuckey Weber Date: Wed, 18 Dec 2024 09:27:32 -0500 Subject: [PATCH 3/3] Move VTTCue.region to region feature --- features/webvtt-cue-settings.yml | 1 - features/webvtt-cue-settings.yml.dist | 8 -------- features/webvtt-regions.yml | 1 + features/webvtt-regions.yml.dist | 14 +++++++++++--- 4 files changed, 12 insertions(+), 12 deletions(-) diff --git a/features/webvtt-cue-settings.yml b/features/webvtt-cue-settings.yml index 339c93975fb..8551690b552 100644 --- a/features/webvtt-cue-settings.yml +++ b/features/webvtt-cue-settings.yml @@ -13,7 +13,6 @@ compat_features: - api.VTTCue.align - api.VTTCue.line - api.VTTCue.position - - api.VTTCue.region - api.VTTCue.size - api.VTTCue.snapToLines - api.VTTCue.vertical diff --git a/features/webvtt-cue-settings.yml.dist b/features/webvtt-cue-settings.yml.dist index 9b78b24ff6b..1fe826fd712 100644 --- a/features/webvtt-cue-settings.yml.dist +++ b/features/webvtt-cue-settings.yml.dist @@ -54,11 +54,3 @@ compat_features: # safari: "7" # safari_ios: "7" - css.selectors.cue.selector_argument - - # baseline: false - # support: - # firefox: "59" - # firefox_android: "59" - # safari: "14.1" - # safari_ios: "14.5" - - api.VTTCue.region diff --git a/features/webvtt-regions.yml b/features/webvtt-regions.yml index cb59c18c73d..b869ffc218c 100644 --- a/features/webvtt-regions.yml +++ b/features/webvtt-regions.yml @@ -2,6 +2,7 @@ name: WebVTT regions description: WebVTT regions set the areas of the video where captions or subtitles should be rendered, such as placing roll-up captions used for live captions. spec: https://w3c.github.io/webvtt/#regions compat_features: + - api.VTTCue.region - api.VTTRegion - api.VTTRegion.VTTRegion - api.VTTRegion.id diff --git a/features/webvtt-regions.yml.dist b/features/webvtt-regions.yml.dist index afef9af520d..eac0f3282d4 100644 --- a/features/webvtt-regions.yml.dist +++ b/features/webvtt-regions.yml.dist @@ -6,8 +6,8 @@ status: support: firefox: "59" firefox_android: "59" - safari: "12.1" - safari_ios: "12.2" + safari: "14.1" + safari_ios: "14.5" compat_features: # baseline: false # support: @@ -25,7 +25,6 @@ compat_features: - api.VTTRegion.viewportAnchorY - api.VTTRegion.width - # ⬇️ Same status as overall feature ⬇️ # baseline: false # support: # firefox: "59" @@ -33,3 +32,12 @@ compat_features: # safari: "12.1" # safari_ios: "12.2" - api.VTTRegion.lines + + # ⬇️ Same status as overall feature ⬇️ + # baseline: false + # support: + # firefox: "59" + # firefox_android: "59" + # safari: "14.1" + # safari_ios: "14.5" + - api.VTTCue.region