From 02440547bc7d564eff52d749123742a9f7f1c5e3 Mon Sep 17 00:00:00 2001 From: James Stuckey Weber Date: Wed, 18 Dec 2024 12:05:18 -0500 Subject: [PATCH 1/4] Add secure context and iframe to gamepad --- features/gamepad-haptics.yml | 1 + features/gamepad-haptics.yml.dist | 6 ++++++ features/gamepad-vr.yml | 1 + features/gamepad-vr.yml.dist | 15 +++++++++++++-- features/gamepad.yml | 5 +++++ features/gamepad.yml.dist | 17 +++++++++++++++++ 6 files changed, 43 insertions(+), 2 deletions(-) diff --git a/features/gamepad-haptics.yml b/features/gamepad-haptics.yml index b7152252c5c..2990c1d259d 100644 --- a/features/gamepad-haptics.yml +++ b/features/gamepad-haptics.yml @@ -16,3 +16,4 @@ compat_features: - api.GamepadHapticActuator.playEffect.params_rightTrigger_parameter - api.GamepadHapticActuator.playEffect.type_trigger-rumble - api.GamepadHapticActuator.reset + - api.GamepadHapticActuator.secure_context_required diff --git a/features/gamepad-haptics.yml.dist b/features/gamepad-haptics.yml.dist index 6507dd44596..e9b74937f79 100644 --- a/features/gamepad-haptics.yml.dist +++ b/features/gamepad-haptics.yml.dist @@ -54,3 +54,9 @@ compat_features: # firefox_android: "55" - api.Gamepad.hapticActuators - api.GamepadHapticActuator.pulse + + # baseline: false + # support: + # firefox: "91" + # firefox_android: "91" + - api.GamepadHapticActuator.secure_context_required diff --git a/features/gamepad-vr.yml b/features/gamepad-vr.yml index dd6a331cae5..62f514e4242 100644 --- a/features/gamepad-vr.yml +++ b/features/gamepad-vr.yml @@ -14,3 +14,4 @@ compat_features: - api.GamepadPose.linearVelocity - api.GamepadPose.orientation - api.GamepadPose.position + - api.GamepadPose.secure_context_required diff --git a/features/gamepad-vr.yml.dist b/features/gamepad-vr.yml.dist index 41345082244..f92dac60190 100644 --- a/features/gamepad-vr.yml.dist +++ b/features/gamepad-vr.yml.dist @@ -4,9 +4,13 @@ status: baseline: false support: - firefox: "55" - firefox_android: "55" + firefox: "91" + firefox_android: "91" compat_features: + # baseline: false + # support: + # firefox: "55" + # firefox_android: "55" - api.Gamepad.hand - api.Gamepad.pose - api.GamepadPose @@ -18,3 +22,10 @@ compat_features: - api.GamepadPose.linearVelocity - api.GamepadPose.orientation - api.GamepadPose.position + + # ⬇️ Same status as overall feature ⬇️ + # baseline: false + # support: + # firefox: "91" + # firefox_android: "91" + - api.GamepadPose.secure_context_required diff --git a/features/gamepad.yml b/features/gamepad.yml index d79cc3fc238..292bb834742 100644 --- a/features/gamepad.yml +++ b/features/gamepad.yml @@ -13,13 +13,18 @@ compat_features: - api.Gamepad.id - api.Gamepad.index - api.Gamepad.mapping + - api.Gamepad.secure_context_required - api.Gamepad.timestamp - api.GamepadButton - api.GamepadButton.pressed + - api.GamepadButton.secure_context_required - api.GamepadButton.value - api.Navigator.getGamepads + - api.Navigator.getGamepads.secure_context_required - api.GamepadEvent - api.GamepadEvent.GamepadEvent - api.GamepadEvent.gamepad + - api.GamepadEvent.secure_context_required - api.Window.gamepadconnected_event - api.Window.gamepaddisconnected_event + - html.elements.iframe.allow.gamepad diff --git a/features/gamepad.yml.dist b/features/gamepad.yml.dist index a6c917d29a6..7404894034c 100644 --- a/features/gamepad.yml.dist +++ b/features/gamepad.yml.dist @@ -74,3 +74,20 @@ compat_features: # safari_ios: "16" - api.Window.gamepadconnected_event - api.Window.gamepaddisconnected_event + + # baseline: false + # support: + # firefox: "91" + # firefox_android: "91" + - api.Gamepad.secure_context_required + - api.GamepadButton.secure_context_required + - api.GamepadEvent.secure_context_required + + # baseline: false + # support: + # firefox: "91" + - api.Navigator.getGamepads.secure_context_required + + # baseline: false + # support: {} + - html.elements.iframe.allow.gamepad From 5977b11783030f8dc669311aae78f0c823695279 Mon Sep 17 00:00:00 2001 From: James Stuckey Weber Date: Wed, 18 Dec 2024 12:06:47 -0500 Subject: [PATCH 2/4] Add compute from to gamepad-vr --- features/gamepad-vr.yml | 4 ++++ features/gamepad-vr.yml.dist | 6 +++--- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/features/gamepad-vr.yml b/features/gamepad-vr.yml index 62f514e4242..758c05c3c31 100644 --- a/features/gamepad-vr.yml +++ b/features/gamepad-vr.yml @@ -2,6 +2,10 @@ name: Gamepad VR hands and poses description: The `hand` and `pose` properties of a `Gamepad` object represent the position in space and the hand that WebVR controllers are held in. spec: https://w3c.github.io/gamepad/extensions.html group: gamepad +status: + compute_from: + - api.Gamepad.hand + - api.Gamepad.pose compat_features: - api.Gamepad.hand - api.Gamepad.pose diff --git a/features/gamepad-vr.yml.dist b/features/gamepad-vr.yml.dist index f92dac60190..01e2a75461e 100644 --- a/features/gamepad-vr.yml.dist +++ b/features/gamepad-vr.yml.dist @@ -4,9 +4,10 @@ status: baseline: false support: - firefox: "91" - firefox_android: "91" + firefox: "55" + firefox_android: "55" compat_features: + # ⬇️ Same status as overall feature ⬇️ # baseline: false # support: # firefox: "55" @@ -23,7 +24,6 @@ compat_features: - api.GamepadPose.orientation - api.GamepadPose.position - # ⬇️ Same status as overall feature ⬇️ # baseline: false # support: # firefox: "91" From 1d1b10c7ad85262fb2405c4bbe2474ab649941de Mon Sep 17 00:00:00 2001 From: James Stuckey Weber Date: Wed, 18 Dec 2024 12:09:53 -0500 Subject: [PATCH 3/4] Lint --- features/gamepad-vr.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/features/gamepad-vr.yml b/features/gamepad-vr.yml index 758c05c3c31..ee71ce0161f 100644 --- a/features/gamepad-vr.yml +++ b/features/gamepad-vr.yml @@ -3,7 +3,7 @@ description: The `hand` and `pose` properties of a `Gamepad` object represent th spec: https://w3c.github.io/gamepad/extensions.html group: gamepad status: - compute_from: + compute_from: - api.Gamepad.hand - api.Gamepad.pose compat_features: From 45a525e7de59077eb86c9d5e2abbee75137c87d9 Mon Sep 17 00:00:00 2001 From: James Stuckey Weber Date: Wed, 18 Dec 2024 13:12:19 -0500 Subject: [PATCH 4/4] Change gamepad compute_from --- features/gamepad.yml | 2 +- features/gamepad.yml.dist | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/features/gamepad.yml b/features/gamepad.yml index 292bb834742..a1fb4b51c09 100644 --- a/features/gamepad.yml +++ b/features/gamepad.yml @@ -4,7 +4,7 @@ spec: https://w3c.github.io/gamepad/ caniuse: gamepad group: gamepad status: - compute_from: api.Gamepad + compute_from: api.Navigator.getGamepads compat_features: - api.Gamepad - api.Gamepad.axes diff --git a/features/gamepad.yml.dist b/features/gamepad.yml.dist index 7404894034c..973617bff79 100644 --- a/features/gamepad.yml.dist +++ b/features/gamepad.yml.dist @@ -6,15 +6,14 @@ status: baseline_low_date: 2017-03-27 baseline_high_date: 2019-09-27 support: - chrome: "21" - chrome_android: "25" + chrome: "35" + chrome_android: "35" edge: "12" firefox: "29" firefox_android: "32" safari: "10.1" safari_ios: "10.3" compat_features: - # ⬇️ Same status as overall feature ⬇️ # baseline: high # baseline_low_date: 2017-03-27 # baseline_high_date: 2019-09-27 @@ -52,6 +51,7 @@ compat_features: # safari_ios: "10.3" - api.Gamepad.connected + # ⬇️ Same status as overall feature ⬇️ # baseline: high # baseline_low_date: 2017-03-27 # baseline_high_date: 2019-09-27