From a04f2e6fe9a362c999ef993c9b2bccfa82df7926 Mon Sep 17 00:00:00 2001 From: Patrick Brosset Date: Tue, 11 Feb 2025 10:24:01 +0100 Subject: [PATCH 1/5] Discouraged cssom interfaces --- features/css-object-model-discouraged.yml | 37 ++++++++++++++ .../css-object-model-discouraged.yml.dist | 51 +++++++++++++++++++ 2 files changed, 88 insertions(+) create mode 100644 features/css-object-model-discouraged.yml create mode 100644 features/css-object-model-discouraged.yml.dist diff --git a/features/css-object-model-discouraged.yml b/features/css-object-model-discouraged.yml new file mode 100644 index 00000000000..d065c28d517 --- /dev/null +++ b/features/css-object-model-discouraged.yml @@ -0,0 +1,37 @@ +name: CSS object model (discouraged) +description: The superseded DOM level 2 style specification defined interfaces to access and modify CSS styles, which are now excluded from the CSS Object Model. +spec: hhttps://www.w3.org/TR/DOM-Level-2-Style/ +group: cssom +discouraged: + according_to: + - https://www.w3.org/TR/DOM-Level-2-Style/#Overview-status + alternatives: + - css-object-model +compat_features: + - api.CSSPrimitiveValue + - api.CSSPrimitiveValue.getCounterValue + - api.CSSPrimitiveValue.getFloatValue + - api.CSSPrimitiveValue.getRGBColorValue + - api.CSSPrimitiveValue.getRectValue + - api.CSSPrimitiveValue.getStringValue + - api.CSSPrimitiveValue.primitiveType + - api.CSSPrimitiveValue.setFloatValue + - api.CSSPrimitiveValue.setStringValue + - api.CSSValue + - api.CSSValue.cssText + - api.CSSValue.cssValueType + - api.CSSValueList + - api.CSSValueList.item + - api.CSSValueList.length + - api.CSSValueList + - api.CSSValueList.item + - api.CSSValueList.length + - api.Counter + - api.Counter.identifier + - api.Counter.listStyle + - api.Counter.separator + - api.Rect + - api.Rect.bottom + - api.Rect.left + - api.Rect.right + - api.Rect.top diff --git a/features/css-object-model-discouraged.yml.dist b/features/css-object-model-discouraged.yml.dist new file mode 100644 index 00000000000..45b347910fe --- /dev/null +++ b/features/css-object-model-discouraged.yml.dist @@ -0,0 +1,51 @@ +# Generated from: css-object-model-discouraged.yml +# Do not edit this file by hand. Edit the source file instead! + +status: + baseline: false + support: + safari: "10" + safari_ios: "10" +compat_features: + # baseline: false + # support: + # safari: "3" + # safari_ios: "1" + - api.CSSPrimitiveValue + - api.CSSPrimitiveValue.getCounterValue + - api.CSSPrimitiveValue.getFloatValue + - api.CSSPrimitiveValue.getRGBColorValue + - api.CSSPrimitiveValue.getRectValue + - api.CSSPrimitiveValue.getStringValue + - api.CSSPrimitiveValue.setFloatValue + - api.CSSPrimitiveValue.setStringValue + - api.CSSValue + - api.CSSValueList + - api.CSSValueList + - api.CSSValueList.item + - api.CSSValueList.item + - api.Counter + - api.Counter.identifier + - api.Counter.listStyle + - api.Counter.separator + - api.Rect + - api.Rect.bottom + - api.Rect.left + - api.Rect.right + - api.Rect.top + + # baseline: false + # support: + # safari: "7" + # safari_ios: "7" + - api.CSSPrimitiveValue.primitiveType + - api.CSSValue.cssText + - api.CSSValue.cssValueType + + # ⬇️ Same status as overall feature ⬇️ + # baseline: false + # support: + # safari: "10" + # safari_ios: "10" + - api.CSSValueList.length + - api.CSSValueList.length From 56d075fd980a1ef239c1379f3ae748e22d4a8c5a Mon Sep 17 00:00:00 2001 From: Patrick Brosset Date: Tue, 11 Feb 2025 10:40:23 +0100 Subject: [PATCH 2/5] Remove dup keys --- features/css-object-model-discouraged.yml | 3 --- features/css-object-model-discouraged.yml.dist | 3 --- 2 files changed, 6 deletions(-) diff --git a/features/css-object-model-discouraged.yml b/features/css-object-model-discouraged.yml index d065c28d517..0476eb2b2a4 100644 --- a/features/css-object-model-discouraged.yml +++ b/features/css-object-model-discouraged.yml @@ -23,9 +23,6 @@ compat_features: - api.CSSValueList - api.CSSValueList.item - api.CSSValueList.length - - api.CSSValueList - - api.CSSValueList.item - - api.CSSValueList.length - api.Counter - api.Counter.identifier - api.Counter.listStyle diff --git a/features/css-object-model-discouraged.yml.dist b/features/css-object-model-discouraged.yml.dist index 45b347910fe..6e1f25aec30 100644 --- a/features/css-object-model-discouraged.yml.dist +++ b/features/css-object-model-discouraged.yml.dist @@ -21,8 +21,6 @@ compat_features: - api.CSSPrimitiveValue.setStringValue - api.CSSValue - api.CSSValueList - - api.CSSValueList - - api.CSSValueList.item - api.CSSValueList.item - api.Counter - api.Counter.identifier @@ -48,4 +46,3 @@ compat_features: # safari: "10" # safari_ios: "10" - api.CSSValueList.length - - api.CSSValueList.length From 04755fb5b558c714f903185c8d6f94d4450e1f5d Mon Sep 17 00:00:00 2001 From: Patrick Brosset Date: Tue, 11 Feb 2025 10:49:53 +0100 Subject: [PATCH 3/5] Add superseded dom level 2 style spec --- scripts/specs.ts | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/scripts/specs.ts b/scripts/specs.ts index 09cf695a7ba..a50fd6ea36d 100644 --- a/scripts/specs.ts +++ b/scripts/specs.ts @@ -100,6 +100,10 @@ const defaultAllowlist: allowlistItem[] = [ [ "https://github.com/tc39/proposal-import-attributes/tree/abca60286360b47f9a6be25a28f489c2cb157beb", "Allowed because import assertions were replaced in-place by import attributes. Remove this exception when javascript.statements.import.import_assertions is dropped from BCD in June 2026." + ], + [ + "https://www.w3.org/TR/DOM-Level-2-Style/", + "Allowed because the css-object-model-discouraged feature points to it." ] ]; From 4f61a21ddf15a035808ade63e3136d2157744fba Mon Sep 17 00:00:00 2001 From: Patrick Brosset Date: Tue, 11 Feb 2025 10:55:20 +0100 Subject: [PATCH 4/5] Found remaining typo --- features/css-object-model-discouraged.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/features/css-object-model-discouraged.yml b/features/css-object-model-discouraged.yml index 0476eb2b2a4..d0c8b548d3e 100644 --- a/features/css-object-model-discouraged.yml +++ b/features/css-object-model-discouraged.yml @@ -1,6 +1,6 @@ name: CSS object model (discouraged) description: The superseded DOM level 2 style specification defined interfaces to access and modify CSS styles, which are now excluded from the CSS Object Model. -spec: hhttps://www.w3.org/TR/DOM-Level-2-Style/ +spec: https://www.w3.org/TR/DOM-Level-2-Style/ group: cssom discouraged: according_to: From 03cb69cdb572d88339a8a05cac5aaccfbb10aaf7 Mon Sep 17 00:00:00 2001 From: Patrick Brosset Date: Tue, 11 Feb 2025 13:45:38 +0100 Subject: [PATCH 5/5] Update features/css-object-model-discouraged.yml Co-authored-by: Daniel D. Beck --- features/css-object-model-discouraged.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/features/css-object-model-discouraged.yml b/features/css-object-model-discouraged.yml index d0c8b548d3e..e250df6303b 100644 --- a/features/css-object-model-discouraged.yml +++ b/features/css-object-model-discouraged.yml @@ -1,5 +1,5 @@ -name: CSS object model (discouraged) -description: The superseded DOM level 2 style specification defined interfaces to access and modify CSS styles, which are now excluded from the CSS Object Model. +name: CSS object model (DOM level 2) +description: The DOM level 2 style specification defined interfaces to access and modify CSS styles, such as `CSSValue` and `CSSPrimitiveValue`, that were later excluded from the CSS object model. spec: https://www.w3.org/TR/DOM-Level-2-Style/ group: cssom discouraged: