Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch the browser logos via `npm` #1604

Merged
merged 2 commits into from Nov 8, 2019

Conversation

@alrra
Copy link
Contributor

alrra commented Nov 4, 2019

Fetch the browser logos via npm (See also / Fix: #1414)

webapp/package.json Outdated Show resolved Hide resolved
@alrra alrra requested a review from Hexcles Nov 4, 2019
@alrra

This comment has been minimized.

Copy link
Contributor Author

alrra commented Nov 4, 2019

FYI @foolip

webapp/package.json Outdated Show resolved Hide resolved
alrra and others added 2 commits Nov 4, 2019
Fix #1414
Always install all packages and then prune to production.
@Hexcles
Hexcles approved these changes Nov 8, 2019
Copy link
Member

Hexcles left a comment

LGTM. Thanks for sending us the patch!

@Hexcles Hexcles merged commit e07051a into web-platform-tests:master Nov 8, 2019
6 of 7 checks passed
6 of 7 checks passed
lint
Details
python_test
Details
go_test
Details
web_components_test web_components_test
Details
go_chrome_test
Details
go_firefox_test
Details
Travis CI - Pull Request Build Passed
Details
@alrra alrra deleted the alrra:browser-logos branch Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.