Permalink
Switch branches/tags
merge_pr_14068 merge_pr_14061 merge_pr_14056 merge_pr_14053 merge_pr_14052 merge_pr_14051 merge_pr_14050 merge_pr_14049 merge_pr_14045 merge_pr_14042 merge_pr_14040 merge_pr_14039 merge_pr_14038 merge_pr_14035 merge_pr_14032 merge_pr_14031 merge_pr_14030 merge_pr_14027 merge_pr_14024 merge_pr_14023 merge_pr_14021 merge_pr_14020 merge_pr_14019 merge_pr_14018 merge_pr_14017 merge_pr_14016 merge_pr_14015 merge_pr_14011 merge_pr_14010 merge_pr_14009 merge_pr_14008 merge_pr_14007 merge_pr_14006 merge_pr_14005 merge_pr_14004 merge_pr_14001 merge_pr_14000 merge_pr_13997 merge_pr_13996 merge_pr_13995 merge_pr_13994 merge_pr_13993 merge_pr_13992 merge_pr_13991 merge_pr_13988 merge_pr_13987 merge_pr_13986 merge_pr_13985 merge_pr_13983 merge_pr_13981 merge_pr_13980 merge_pr_13979 merge_pr_13978 merge_pr_13977 merge_pr_13974 merge_pr_13969 merge_pr_13968 merge_pr_13967 merge_pr_13962 merge_pr_13961 merge_pr_13960 merge_pr_13959 merge_pr_13958 merge_pr_13957 merge_pr_13955 merge_pr_13954 merge_pr_13953 merge_pr_13952 merge_pr_13951 merge_pr_13950 merge_pr_13949 merge_pr_13948 merge_pr_13947 merge_pr_13946 merge_pr_13945 merge_pr_13944 merge_pr_13943 merge_pr_13942 merge_pr_13941 merge_pr_13940 merge_pr_13939 merge_pr_13938 merge_pr_13935 merge_pr_13934 merge_pr_13933 merge_pr_13932 merge_pr_13931 merge_pr_13930 merge_pr_13929 merge_pr_13927 merge_pr_13925 merge_pr_13921 merge_pr_13920 merge_pr_13919 merge_pr_13918 merge_pr_13917 merge_pr_13916 merge_pr_13915 merge_pr_13914 merge_pr_13912
Nothing to show
Find file Copy path
Fetching contributors…
Cannot retrieve contributors at this time
39 lines (29 sloc) 1.5 KB
layout title order
page
Reviewing Tests
-1

In order to encourage a high level of quality in the W3C test suites, test contributions must be reviewed by a peer.

Test Review Policy

The reviewer can be anyone (other than the original test author) that has the required experience with both the spec under test and with the [general test guidelines][general guidelines].

The review must happen in public, but there is no requirement for it to happen in any specific location. In particular if a vendor is submitting tests that have already been publicly reviewed in their own review system, that review may be carried forward. For other tests, we strongly recommend using either Reviewable or GitHub's built-in review tools.

Regardless of what review tool is used, the review must be clearly linked in the pull request.

In general, we tend on the side of merging things with nits (i.e., anything sub-optimal that isn't absolutely required to be right) and then opening issues to leaving pull requests open indefinitely waiting on the original submitter to fix them; when tests are being upstreamed from vendors it is frequently the case that the author has moved on to working on other things as tests frequently only get pushed upstream once the code lands in their implementation.

To assist with test reviews, a [review checklist][] is available.

[general guidelines]: {{ site.baseurl }}{% link _writing-tests/general-guidelines.md %} [review checklist]: {{ site.baseurl }}{% link _reviewing-tests/checklist.md %}