From 039eed9442ced04845a6dc3460107d938bd2b54c Mon Sep 17 00:00:00 2001 From: Oriol Brufau Date: Mon, 4 Mar 2019 08:14:06 -0800 Subject: [PATCH] [css-grid] Always consider baseline shim for the minimum contribution Before this patch, the shim used for baseline alignment is not taken into consideration when calculating the minimum contribution of a grid item if its preferred size is auto, its minimum size is auto, and the max track sizing function is a fixed small value. In this case, the auto minimum size can produce a smaller track than if it was 0. The specification needs to clarify how baseline shims interact with minimum contributions (https://github.com/w3c/csswg-drafts/issues/3660), but the above doesn't make sense. BUG=934535 TEST=external/wpt/css/css-grid/layout-algorithm/grid-minimum-contribution-baseline-shim.html Change-Id: Iafd194ab7e5656b5018e0e36b915ba183bdedd19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1481512 Commit-Queue: Oriol Brufau Reviewed-by: Manuel Rego Reviewed-by: Javier Fernandez Cr-Commit-Position: refs/heads/master@{#637299} --- ...ontribution-baseline-shim-vertical-lr.html | 96 +++++++++++++++++++ ...ontribution-baseline-shim-vertical-rl.html | 96 +++++++++++++++++++ ...id-minimum-contribution-baseline-shim.html | 93 ++++++++++++++++++ 3 files changed, 285 insertions(+) create mode 100644 css/css-grid/layout-algorithm/grid-minimum-contribution-baseline-shim-vertical-lr.html create mode 100644 css/css-grid/layout-algorithm/grid-minimum-contribution-baseline-shim-vertical-rl.html create mode 100644 css/css-grid/layout-algorithm/grid-minimum-contribution-baseline-shim.html diff --git a/css/css-grid/layout-algorithm/grid-minimum-contribution-baseline-shim-vertical-lr.html b/css/css-grid/layout-algorithm/grid-minimum-contribution-baseline-shim-vertical-lr.html new file mode 100644 index 00000000000000..3d1949fc3fa3a1 --- /dev/null +++ b/css/css-grid/layout-algorithm/grid-minimum-contribution-baseline-shim-vertical-lr.html @@ -0,0 +1,96 @@ + + +CSS Grid Layout Test: minimum contribution with baseline-alignment shim + + + + + + + + + +
+ +
+
+
+
+
+ +
+
+
+
+
+ +
+
+
+
+
+ +
+
+
+
+
+ +
+
+
+
+
+ +
+
+
+
+
+ + diff --git a/css/css-grid/layout-algorithm/grid-minimum-contribution-baseline-shim-vertical-rl.html b/css/css-grid/layout-algorithm/grid-minimum-contribution-baseline-shim-vertical-rl.html new file mode 100644 index 00000000000000..e56de9f1b3dae0 --- /dev/null +++ b/css/css-grid/layout-algorithm/grid-minimum-contribution-baseline-shim-vertical-rl.html @@ -0,0 +1,96 @@ + + +CSS Grid Layout Test: minimum contribution with baseline-alignment shim + + + + + + + + + +
+ +
+
+
+
+
+ +
+
+
+
+
+ +
+
+
+
+
+ +
+
+
+
+
+ +
+
+
+
+
+ +
+
+
+
+
+ + diff --git a/css/css-grid/layout-algorithm/grid-minimum-contribution-baseline-shim.html b/css/css-grid/layout-algorithm/grid-minimum-contribution-baseline-shim.html new file mode 100644 index 00000000000000..2bd37eb0f0da59 --- /dev/null +++ b/css/css-grid/layout-algorithm/grid-minimum-contribution-baseline-shim.html @@ -0,0 +1,93 @@ + + +CSS Grid Layout Test: minimum contribution with baseline-alignment shim + + + + + + + + + +
+ +
+
+
+
+
+ +
+
+
+
+
+ +
+
+
+
+
+ +
+
+
+
+
+ +
+
+
+
+
+ +
+
+
+
+
+ +