From 29d4f9513ad84c09f54199ffc157a0f9ce7d1e90 Mon Sep 17 00:00:00 2001 From: Nick Burris Date: Fri, 18 Nov 2022 11:02:48 -0800 Subject: [PATCH] [SPC] Add Secure Payment Confirmation opt out WPT Adds chromedriver support and web platform test for opt-out for SPC. The WPT passes locally with SPC opt out enabled (currently disabled behind a flag). There's a small change in the SPC MVC logic, since opt-out can now happen by calling SPCController::OnOptOut directly, which resulted in the dialog view calling back to OnCancel when the dialog closes since it didn't know opt-out was programmatically invoked. This is fixed by having the controller set a bit on the model which the view checks. Spec PR: https://github.com/w3c/secure-payment-confirmation/pull/215 Bug: 1385865 Change-Id: I777e92b5110785415de68ef9f0497905598e4897 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4030688 Commit-Queue: Nick Burris Reviewed-by: Stephen McGruer Reviewed-by: Andrey Kosyakov Cr-Commit-Position: refs/heads/main@{#1073462} --- resources/testharness.js | 3 +- .../authentication-optout.https.html | 50 +++++++++++++++++++ 2 files changed, 52 insertions(+), 1 deletion(-) create mode 100644 secure-payment-confirmation/authentication-optout.https.html diff --git a/resources/testharness.js b/resources/testharness.js index 7ac363217bdce4..55aaa582c53eff 100644 --- a/resources/testharness.js +++ b/resources/testharness.js @@ -2246,7 +2246,8 @@ ReadOnlyError: 0, VersionError: 0, OperationError: 0, - NotAllowedError: 0 + NotAllowedError: 0, + OptOutError: 0 }; var code_name_map = {}; diff --git a/secure-payment-confirmation/authentication-optout.https.html b/secure-payment-confirmation/authentication-optout.https.html new file mode 100644 index 00000000000000..ea4d18ea1ae7e0 --- /dev/null +++ b/secure-payment-confirmation/authentication-optout.https.html @@ -0,0 +1,50 @@ + + +Test for the 'secure-payment-confirmation' payment method authentication - user opt out case + + + + + + + \ No newline at end of file