From 451877b79e3d6b4f818de537a021c71f1aa78063 Mon Sep 17 00:00:00 2001 From: Alison Maher Date: Sat, 21 Nov 2020 00:21:55 -0800 Subject: [PATCH] Force other forced color properties at used value time Forced colors should now happen at used value time. This change adjusts the used value of text-decoration-color, -internal-visited-text- decoration-color, column-rule-color, -internal-visited-column-rule-color, -webkit-tap-highlight-color, -webkit-text-emphasis-color, and -internal- visited-text-emphasis-color to take forced colors into account. No internal properties were needed since we only ever force these set of properties to currentColor in forced colors mode. The only remaining property to move to used value time is 'color'. Bug: 970285 Change-Id: Ica77609ce631f1768bdd52753535a484a32d3a3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523664 Commit-Queue: Alison Maher Reviewed-by: Anders Hartvoll Ruud Cr-Commit-Position: refs/heads/master@{#829973} --- forced-colors-mode/forced-colors-mode-04.html | 24 ------------------- forced-colors-mode/forced-colors-mode-32.html | 22 ----------------- forced-colors-mode/forced-colors-mode-40.html | 10 +++++++- 3 files changed, 9 insertions(+), 47 deletions(-) delete mode 100644 forced-colors-mode/forced-colors-mode-04.html delete mode 100644 forced-colors-mode/forced-colors-mode-32.html diff --git a/forced-colors-mode/forced-colors-mode-04.html b/forced-colors-mode/forced-colors-mode-04.html deleted file mode 100644 index 42b4efdba71bd9..00000000000000 --- a/forced-colors-mode/forced-colors-mode-04.html +++ /dev/null @@ -1,24 +0,0 @@ - - -Forced colors mode - webkit-tap-highlight-color. - - - - - -

- - This link color should be overridden when forced colors mode is enabled. - -

- - - diff --git a/forced-colors-mode/forced-colors-mode-32.html b/forced-colors-mode/forced-colors-mode-32.html deleted file mode 100644 index bd3595bf3bf33d..00000000000000 --- a/forced-colors-mode/forced-colors-mode-32.html +++ /dev/null @@ -1,22 +0,0 @@ - - -Forced colors mode - webkit-tap-highlight-color with sys color. - - - - - - This link color should not be overridden when forced colors mode is enabled. - - - - diff --git a/forced-colors-mode/forced-colors-mode-40.html b/forced-colors-mode/forced-colors-mode-40.html index 71ac4c9ea820c5..84d16ec840f02f 100644 --- a/forced-colors-mode/forced-colors-mode-40.html +++ b/forced-colors-mode/forced-colors-mode-40.html @@ -10,9 +10,13 @@ div { background-color: green; border-color: green; + column-rule-color: green; fill: green; outline-color: green; stroke: green; + text-decoration-color: green; + -webkit-tap-highlight-color: green; + -webkit-text-emphasis-color: green; }
@@ -26,9 +30,13 @@ "border-left-color", "border-right-color", "border-top-color", + "column-rule-color", "fill", "outline-color", - "stroke" + "stroke", + "text-decoration-color", + "-webkit-tap-highlight-color", + "-webkit-text-emphasis-color" ]; for (let property of properties_to_test) { test(function() {