From 4c5408d354ca9eb460bec40db10ae941a20ec865 Mon Sep 17 00:00:00 2001 From: Anders Hartvoll Ruud Date: Tue, 10 Aug 2021 00:43:49 -0700 Subject: [PATCH] Don't modify computed value of 'contain' for locked elements DisplayLockContext::AdjustElementStyle currently modifies the computed value of 'contain'. It should not [1]. Instead we store a bit on ComputedStyle to indicate whether or not the element should skip its contents [2], and use this flag used- value-time to request the appropriate containment. [1] https://github.com/w3c/csswg-drafts/issues/6246 [2] https://drafts.csswg.org/css-contain-2/#skips-its-contents Fixed: 1203627 Change-Id: I5571b0a5fac1b89903c03a256a2b144bddcd5040 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3081725 Commit-Queue: Anders Hartvoll Ruud Reviewed-by: vmpstr Cr-Commit-Position: refs/heads/master@{#910192} --- .../content-visibility-026.html | 110 +++--------------- 1 file changed, 13 insertions(+), 97 deletions(-) diff --git a/css/css-contain/content-visibility/content-visibility-026.html b/css/css-contain/content-visibility/content-visibility-026.html index 53155002ae7418..17ec9a21d56839 100644 --- a/css/css-contain/content-visibility/content-visibility-026.html +++ b/css/css-contain/content-visibility/content-visibility-026.html @@ -1,115 +1,31 @@ -Content Visibility: containment added +Content Visibility: Computed Values - - - - + + -
-
-
-