From 5569f87494f50e4d3c55e925f5bc5f8c27c9200d Mon Sep 17 00:00:00 2001 From: Mason Freed Date: Fri, 1 Apr 2022 12:23:41 -0700 Subject: [PATCH] Remove scroll-to-light-dismiss behavior from popups Per [1], we have resolved that scrolling should *not* light dismiss popups. This CL implements that change. [1] https://github.com/openui/open-ui/issues/240#issuecomment-1084971517 Bug: 1307772 Change-Id: I8749574733892bc33c1b19af954badb367d24139 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3564406 Reviewed-by: Joey Arhar Commit-Queue: Mason Freed Cr-Commit-Position: refs/heads/main@{#988054} --- ...pup-light-dismiss-on-scroll.tentative.html | 47 ------------------- ...pup-light-dismiss-on-scroll.tentative.html | 44 +++++++++++------ 2 files changed, 30 insertions(+), 61 deletions(-) delete mode 100644 html/semantics/interactive-elements/the-popup-element/popup-light-dismiss-on-scroll.tentative.html diff --git a/html/semantics/interactive-elements/the-popup-element/popup-light-dismiss-on-scroll.tentative.html b/html/semantics/interactive-elements/the-popup-element/popup-light-dismiss-on-scroll.tentative.html deleted file mode 100644 index 4f14dd7ae774b3..00000000000000 --- a/html/semantics/interactive-elements/the-popup-element/popup-light-dismiss-on-scroll.tentative.html +++ /dev/null @@ -1,47 +0,0 @@ - - - -Popup light dismiss on scroll - - - - - -
- Scroll me

- Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt - ut labore et dolore magna aliqua. Enim ut sem viverra aliquet eget sit amet tellus. Massa - sed elementum tempus egestas sed sed risus pretium. Felis bibendum ut tristique et egestas - quis. Tortor dignissim convallis aenean et. Eu mi bibendum neque egestas congue quisque -
- -This is popup 1
 -This is popup 2 - - - - - diff --git a/html/semantics/popups/popup-light-dismiss-on-scroll.tentative.html b/html/semantics/popups/popup-light-dismiss-on-scroll.tentative.html index d1ae7fc4c80ed5..bafa50dae36330 100644 --- a/html/semantics/popups/popup-light-dismiss-on-scroll.tentative.html +++ b/html/semantics/popups/popup-light-dismiss-on-scroll.tentative.html @@ -1,9 +1,10 @@ -Popup light dismiss on scroll +Popup should *not* light dismiss on scroll + @@ -15,8 +16,12 @@ quis. Tortor dignissim convallis aenean et. Eu mi bibendum neque egestas congue quisque -
This is popup 1
-
This is popup 2
+
+ This is popup 1 +
+ This is popup 2 +
+