Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Passing Android device serial to chromedriver.
The Android device serial number, specified by the --device-serial
command-line option, was never passed to the chromedriver server.
This resulted in chromedriver always using the first device or
emulator.

Bug: None
Change-Id: I1a4cb1c45739f24da5ea0f6cfb3726c84ff68fa1
  • Loading branch information
cmumford authored and chromium-wpt-export-bot committed Oct 9, 2019
1 parent 4c1bbd4 commit 58a5244
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions tools/wptrunner/wptrunner/browsers/android_webview.py
Expand Up @@ -53,6 +53,8 @@ def executor_kwargs(test_type, server_config, cache_manager, run_info_data,
capabilities["goog:chromeOptions"]["androidPackage"] = \
"org.chromium.webview_shell"
capabilities["goog:chromeOptions"]["androidActivity"] = ".WebPlatformTestsActivity"
if 'device_serial' in kwargs:
capabilities["goog:chromeOptions"]["androidDeviceSerial"] = kwargs['device_serial']

# Workaround: driver.quit() cannot quit SystemWebViewShell.
executor_kwargs["pause_after_test"] = False
Expand Down

0 comments on commit 58a5244

Please sign in to comment.