Skip to content
Permalink
Browse files

Fix #9750: bind_hostname needs to be a Python bool

db55c16 fixed this for Servo;
"true"/"false" worked when it was interpolated as JSON, but that is no
longer the case since cb2d75f (#9480).
  • Loading branch information...
gsnedders committed Mar 2, 2018
1 parent ca79597 commit 9b93da02ede9ee422ebbc68604cf025f2aaf780c
@@ -60,7 +60,7 @@ def env_extras(**kwargs):


def env_options():
return {"bind_hostname": "true"}
return {"bind_hostname": True}


class ChromeBrowser(Browser):
@@ -68,7 +68,7 @@ def env_extras(**kwargs):


def env_options():
return {"bind_hostname": "true"}
return {"bind_hostname": True}


class ChromeAndroidBrowser(Browser):
@@ -38,7 +38,7 @@ def env_extras(**kwargs):
return []

def env_options():
return {"bind_hostname": "true",
return {"bind_hostname": True,
"supports_debugger": False}

class EdgeBrowser(Browser):
@@ -124,7 +124,7 @@ def env_options():
# https://github.com/w3c/web-platform-tests/pull/9480
return {"host_ip": "127.0.0.1",
"host": "web-platform.test",
"bind_hostname": "false",
"bind_hostname": False,
"certificate_domain": "web-platform.test",
"supports_debugger": True}

@@ -42,7 +42,7 @@ def env_extras(**kwargs):
return []

def env_options():
return {"bind_hostname": "true",
return {"bind_hostname": True,
"supports_debugger": False}

class InternetExplorerBrowser(Browser):
@@ -60,7 +60,7 @@ def env_extras(**kwargs):


def env_options():
return {"bind_hostname": "true"}
return {"bind_hostname": True}


class OperaBrowser(Browser):
@@ -44,7 +44,7 @@ def env_extras(**kwargs):


def env_options():
return {"bind_hostname": "true"}
return {"bind_hostname": True}


class SafariBrowser(Browser):
@@ -113,7 +113,7 @@ def env_extras(**kwargs):


def env_options():
return {"bind_hostname": "true",
return {"bind_hostname": True,
"supports_debugger": False}


@@ -55,7 +55,7 @@ def env_extras(**kwargs):
def env_options():
return {"host_ip": "127.0.0.1",
"host": "web-platform.test",
"bind_hostname": "true",
"bind_hostname": True,
"testharnessreport": "testharnessreport-servodriver.js",
"supports_debugger": True}

@@ -39,15 +39,7 @@ def test_load_all_products(product):


@active_products("product", marks={
"firefox": pytest.mark.xfail(reason="#9750"),
"chrome": pytest.mark.xfail(reason="#9750"),
"chrome_android": pytest.mark.xfail(reason="#9750"),
"edge": pytest.mark.xfail(reason="#9750"),
"ie": pytest.mark.xfail(reason="#9750"),
"opera": pytest.mark.xfail(reason="#9750"),
"safari": pytest.mark.xfail(reason="#9750"),
"sauce": pytest.mark.skip("needs env extras kwargs"),
"servodriver": pytest.mark.xfail(reason="#9750"),
})
def test_server_start_config(product):
(check_args,

0 comments on commit 9b93da0

Please sign in to comment.
You can’t perform that action at this time.