From b85049cdb2a4c22b319c55cc30f16f18900b5bde Mon Sep 17 00:00:00 2001 From: Ian Kilpatrick Date: Thu, 3 Jun 2021 14:51:58 -0700 Subject: [PATCH] [GridNG] Do an additional pass when the min/max depends on block-size As above. Previously legacy grid wasn't applying this rule directly, but if a grid was laid out twice, it'd use stale information to get the "correct" result on the 2nd layout pass. This fixed NG by explicity performing a 2nd pass. Added tests which quote the relevant part of the specification. Bug: 1045599, 1213878 Change-Id: Ia2e977356099642f3b6d1276bfcad0e201695541 --- .../grid-item-inline-contribution-001.html | 10 +++++++ ...tem-inline-contribution-002.tentative.html | 27 +++++++++++++++++++ ...tem-inline-contribution-003.tentative.html | 27 +++++++++++++++++++ 3 files changed, 64 insertions(+) create mode 100644 css/css-grid/grid-items/grid-item-inline-contribution-001.html create mode 100644 css/css-grid/grid-items/grid-item-inline-contribution-002.tentative.html create mode 100644 css/css-grid/grid-items/grid-item-inline-contribution-003.tentative.html diff --git a/css/css-grid/grid-items/grid-item-inline-contribution-001.html b/css/css-grid/grid-items/grid-item-inline-contribution-001.html new file mode 100644 index 000000000000000..ebed26b3326e94b --- /dev/null +++ b/css/css-grid/grid-items/grid-item-inline-contribution-001.html @@ -0,0 +1,10 @@ + + + + +

Test passes if there is a filled green square and no red.

+
+
+ +
+
diff --git a/css/css-grid/grid-items/grid-item-inline-contribution-002.tentative.html b/css/css-grid/grid-items/grid-item-inline-contribution-002.tentative.html new file mode 100644 index 000000000000000..abf175d81431f9f --- /dev/null +++ b/css/css-grid/grid-items/grid-item-inline-contribution-002.tentative.html @@ -0,0 +1,27 @@ + + + + + +

Test passes if there is a filled green square and no red.

+
+
+ +
+
+
+
+
diff --git a/css/css-grid/grid-items/grid-item-inline-contribution-003.tentative.html b/css/css-grid/grid-items/grid-item-inline-contribution-003.tentative.html new file mode 100644 index 000000000000000..0488165abe103cb --- /dev/null +++ b/css/css-grid/grid-items/grid-item-inline-contribution-003.tentative.html @@ -0,0 +1,27 @@ + + + + + +

Test passes if there is a filled green square and no red.

+
+
+ +
+
+
+
+