From c220898a5aef2d4a09bb3534c8638da2938fce37 Mon Sep 17 00:00:00 2001
From: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Mon, 15 Mar 2021 16:09:40 -0700
Subject: [PATCH] Fix painting of composited overflow controls with
 visibility:hidden

We can have a composited scroller with visibility:hidden if it has
visibility:visible descendants. We should skip painting of overflow
controls in the case. Ideally we should not create composited
overflow control layers, but I would not touch the
pre-CompositeAfterPaint code for the rare case.

Bug: 1187818, 1185968
Change-Id: If59049a685fa153b6538f8ca2424792904096000
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2761470
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#863011}
---
 ...w-scroll-resize-visibility-hidden-ref.html | 21 ++++++++++++++++
 ...rflow-scroll-resize-visibility-hidden.html | 25 +++++++++++++++++++
 2 files changed, 46 insertions(+)
 create mode 100644 css/css-overflow/overflow-scroll-resize-visibility-hidden-ref.html
 create mode 100644 css/css-overflow/overflow-scroll-resize-visibility-hidden.html
diff --git a/css/css-overflow/overflow-scroll-resize-visibility-hidden-ref.html b/css/css-overflow/overflow-scroll-resize-visibility-hidden-ref.html
new file mode 100644
index 00000000000000..571ba348df4b2d
--- /dev/null
+++ b/css/css-overflow/overflow-scroll-resize-visibility-hidden-ref.html
@@ -0,0 +1,21 @@
+﻿<!DOCTYPE html>
+<style>
+.scroller {
+  width: 100px;
+  height: 100px;
+  overflow: scroll;
+  /* to make the scroller a white mask over the content */
+  filter: brightness(0) invert(1);
+  position: relative;
+  top: -200px;
+}
+.content {
+  width: 100px;
+  height: 100px;
+  background: green;
+}
+</style>
+<div class="content"></div>
+<div class="content"></div>
+<div class="scroller"></div>
+<div class="scroller"></div>
diff --git a/css/css-overflow/overflow-scroll-resize-visibility-hidden.html b/css/css-overflow/overflow-scroll-resize-visibility-hidden.html
new file mode 100644
index 00000000000000..e8d0bc91440c7e
--- /dev/null
+++ b/css/css-overflow/overflow-scroll-resize-visibility-hidden.html
@@ -0,0 +1,25 @@
+﻿<!DOCTYPE html>
+<title>CSS Overflow: overflow: scroll with resize: both and visibility: hidden</title>
+<link rel="help" href="https://drafts.csswg.org/css-overflow-3#propdef-overflow">
+<link rel="match" href="overflow-scroll-resize-visibility-hidden-ref.html">
+<style>
+.scroller {
+  overflow: scroll;
+  width: 100px;
+  height: 100px;
+  resize: both;
+  visibility: hidden;
+}
+.content {
+  width: 1000px;
+  height: 1000px;
+  background: green;
+  visibility: visible;
+}
+</style>
+<div class="scroller">
+  <div class="content"></div>
+</div>
+<div class="scroller" style="will-change: transform">
+  <div class="content"></div>
+</div>
