From ded643eb16ac6e4b6a5f7c3f869109faee6556a6 Mon Sep 17 00:00:00 2001
From: Luke Warlow <luke@warlow.dev>
Date: Wed, 29 Nov 2023 14:11:29 -0800
Subject: [PATCH] Change "mute" invoke action to toggleMuted

See https://github.com/openui/open-ui/issues/933 for details

Bug: 1497172, 1497173
Change-Id: I193b9948bd6b296d9a3e85e0dac3de780ae1865f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5073272
Commit-Queue: Luke <lukewarlow156@gmail.com>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1230938}
---
 .../invoketarget-on-audio-behavior.tentative.html    | 12 ++++++------
 .../invoketarget-on-video-behavior.tentative.html    | 12 ++++++------
 2 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/html/semantics/invokers/invoketarget-on-audio-behavior.tentative.html b/html/semantics/invokers/invoketarget-on-audio-behavior.tentative.html
index 02f3ff6d069361..f3abeae165aa26 100644
--- a/html/semantics/invokers/invoketarget-on-audio-behavior.tentative.html
+++ b/html/semantics/invokers/invoketarget-on-audio-behavior.tentative.html
@@ -238,13 +238,13 @@
       invokee.muted = false;
     });
     assert_false(invokee.muted);
-    invokerbutton.setAttribute("invokeaction", "mute");
+    invokerbutton.setAttribute("invokeaction", "toggleMuted");
     await clickOn(invokerbutton);
     await new Promise(resolve => {
       requestAnimationFrame(resolve);
     });
     assert_true(invokee.muted);
-  }, "invoking audio with mute action mutes it");
+  }, "invoking audio with toggleMuted action mutes it");
 
   promise_test(async function (t) {
     t.add_cleanup(async () => {
@@ -257,13 +257,13 @@
       once: true,
     });
     assert_false(invokee.muted);
-    invokerbutton.setAttribute("invokeaction", "mute");
+    invokerbutton.setAttribute("invokeaction", "toggleMuted");
     await clickOn(invokerbutton);
     await new Promise(resolve => {
       requestAnimationFrame(resolve);
     });
     assert_false(invokee.muted);
-  }, "invoking audio with mute action and preventDefault is a no-op");
+  }, "invoking audio with toggleMuted action and preventDefault is a no-op");
 
   promise_test(async function (t) {
     t.add_cleanup(async () => {
@@ -274,12 +274,12 @@
     });
     invokee.muted = true;
     assert_true(invokee.muted);
-    invokerbutton.setAttribute("invokeaction", "mute");
+    invokerbutton.setAttribute("invokeaction", "toggleMuted");
     await clickOn(invokerbutton);
     await new Promise(resolve => {
       requestAnimationFrame(resolve);
     });
     assert_false(invokee.muted);
-  }, "invoking muted audio with mute action unmutes it");
+  }, "invoking muted audio with toggleMuted action unmutes it");
 
 </script>
diff --git a/html/semantics/invokers/invoketarget-on-video-behavior.tentative.html b/html/semantics/invokers/invoketarget-on-video-behavior.tentative.html
index 03312e3fc52cd2..5bbcd83e72ef31 100644
--- a/html/semantics/invokers/invoketarget-on-video-behavior.tentative.html
+++ b/html/semantics/invokers/invoketarget-on-video-behavior.tentative.html
@@ -206,13 +206,13 @@
       invokee.muted = false;
     });
     assert_false(invokee.muted);
-    invokerbutton.setAttribute("invokeaction", "mute");
+    invokerbutton.setAttribute("invokeaction", "toggleMuted");
     await clickOn(invokerbutton);
     await new Promise(resolve => {
       requestAnimationFrame(resolve);
     });
     assert_true(invokee.muted);
-  }, "invoking video with mute action mutes it");
+  }, "invoking video with toggleMuted action mutes it");
 
   promise_test(async function (t) {
     t.add_cleanup(async () => {
@@ -225,13 +225,13 @@
         once: true,
     });
     assert_false(invokee.muted);
-    invokerbutton.setAttribute("invokeaction", "mute");
+    invokerbutton.setAttribute("invokeaction", "toggleMuted");
     await clickOn(invokerbutton);
     await new Promise(resolve => {
       requestAnimationFrame(resolve);
     });
     assert_false(invokee.muted);
-  }, "invoking video with mute action and preventDefault is a no-op");
+  }, "invoking video with toggleMuted action and preventDefault is a no-op");
 
   promise_test(async function (t) {
     t.add_cleanup(async () => {
@@ -242,12 +242,12 @@
     });
     invokee.muted = true;
     assert_true(invokee.muted);
-    invokerbutton.setAttribute("invokeaction", "mute");
+    invokerbutton.setAttribute("invokeaction", "toggleMuted");
     await clickOn(invokerbutton);
     await new Promise(resolve => {
       requestAnimationFrame(resolve);
     });
     assert_false(invokee.muted);
-  }, "invoking muted video with mute action unmutes it");
+  }, "invoking muted video with toggleMuted action unmutes it");
 
 </script>