From e8652a68d1fc31b7a8df18c406b2abc34e65894c Mon Sep 17 00:00:00 2001 From: Aaron Leventhal Date: Tue, 29 Jun 2021 14:09:43 -0700 Subject: [PATCH] with datalist triggers !IsValid() DCHECK 1) Only perform validity checks on truly plain text fields. We considered removing the check, but it still has value in terms of catching situations where the text field structure changes, which have occurred in the past and caused regressions. 2) Remove BrowserAccessibility::IsValid() from non-DCHECK builds. Bug: 1221781 NOTRY: true Change-Id: I5719fa84950f038f19ebe9c616db5946c52e0242 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2983437 Commit-Queue: Aaron Leventhal Commit-Queue: Dominic Mazzoni Auto-Submit: Aaron Leventhal Reviewed-by: Dominic Mazzoni Cr-Commit-Position: refs/heads/master@{#897069} --- accessibility/crashtests/input-time-datalist.html | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 accessibility/crashtests/input-time-datalist.html diff --git a/accessibility/crashtests/input-time-datalist.html b/accessibility/crashtests/input-time-datalist.html new file mode 100644 index 00000000000000..b27b77a7675df0 --- /dev/null +++ b/accessibility/crashtests/input-time-datalist.html @@ -0,0 +1,2 @@ + +