From f27d18849902bd9d995cbcd67342244c0e43b0e8 Mon Sep 17 00:00:00 2001 From: Chris Nardi Date: Mon, 12 Feb 2018 22:41:18 -0800 Subject: [PATCH] Ignore order when parsing inset and color for box-shadow According to the spec [1], box-shadow should allow the inset keyword and a color in any order. Our implementation allowed only 2 out of the 4 possible orders; fix our parsing to match the spec. [1]: https://drafts.csswg.org/css-backgrounds/#typedef-shadow Bug: 811083 Change-Id: I54c3d15c177702624994c45044b446fd82fc9d98 Reviewed-on: https://chromium-review.googlesource.com/911994 Commit-Queue: Chris Nardi Reviewed-by: Emil A Eklund Cr-Commit-Position: refs/heads/master@{#536270} --- css/css-backgrounds/box-shadow-syntax-001.xht | 2 +- css/css-backgrounds/reference/box-shadow-syntax-001.xht | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/css/css-backgrounds/box-shadow-syntax-001.xht b/css/css-backgrounds/box-shadow-syntax-001.xht index 4e32c9fe1686d7..4df5907080d46c 100644 --- a/css/css-backgrounds/box-shadow-syntax-001.xht +++ b/css/css-backgrounds/box-shadow-syntax-001.xht @@ -21,7 +21,7 @@ } .inset { color: green; - height: 13px; + height: 12px; margin: -1px 0 -4px -4px; } diff --git a/css/css-backgrounds/reference/box-shadow-syntax-001.xht b/css/css-backgrounds/reference/box-shadow-syntax-001.xht index 697c21a9824639..34be7bc52f1834 100644 --- a/css/css-backgrounds/reference/box-shadow-syntax-001.xht +++ b/css/css-backgrounds/reference/box-shadow-syntax-001.xht @@ -10,6 +10,7 @@ border: solid green 4px; padding-top: 1px; border-style: none none solid solid; + height: 7px; }