Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testdriver: tabs switch frequently when invokes multiple actions #10398

Closed
Honry opened this issue Apr 10, 2018 · 13 comments
Closed

Testdriver: tabs switch frequently when invokes multiple actions #10398

Honry opened this issue Apr 10, 2018 · 13 comments

Comments

@Honry
Copy link
Contributor

@Honry Honry commented Apr 10, 2018

I encountered this issue when trying to automate test at https://github.com/w3c/web-platform-tests/pull/10396/files#diff-52f806f8477bda3b3246226c740e6cb9

When invokes multiple test_driver actions, the runner will switch tab pages between test page and testharness_runner.html immediately and frequently(one action one switch).

@kereliuk

This comment has been minimized.

Copy link
Contributor

@kereliuk kereliuk commented Apr 10, 2018

Good catch, I'll take a look at this tomorrow.

@foolip

This comment has been minimized.

Copy link
Contributor

@foolip foolip commented Jul 12, 2018

@kereliuk, should this be priority:roadmap, and has the state of things changed in the intervening months? Seems like this is the same window switching that's the reason that fullscreen can't be automated still?

@kereliuk

This comment has been minimized.

Copy link
Contributor

@kereliuk kereliuk commented Jul 16, 2018

Will put on the list for this week, I think the priority should stay the same for now.

chromium-wpt-export-bot pushed a commit that referenced this issue Jul 16, 2018
This makes sure web platform tests for Picture-in-Picture do not time
out when Picture-in-Picture API is not available.

Besides, wpt/picture-in-picture/request-picture-in-picture is split
to work around a flaky timeout in WPT upstream that's related to
#10398

Note: based on #11329

Bug: 806249
Change-Id: I6185253dfa4aae5111e87553581b8464032558d1
aarongable pushed a commit to chromium/chromium that referenced this issue Jul 20, 2018
This makes sure web platform tests for Picture-in-Picture do not time
out when Picture-in-Picture API is not available.

Besides, wpt/picture-in-picture/request-picture-in-picture is split
to work around a flaky timeout in WPT upstream that's related to
web-platform-tests/wpt#10398

Note: based on web-platform-tests/wpt#11329

Bug: 806249
Change-Id: I6185253dfa4aae5111e87553581b8464032558d1
Reviewed-on: https://chromium-review.googlesource.com/1107626
Reviewed-by: Robert Ma <robertma@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/master@{#576804}
chromium-wpt-export-bot pushed a commit that referenced this issue Jul 20, 2018
This makes sure web platform tests for Picture-in-Picture do not time
out when Picture-in-Picture API is not available.

Besides, wpt/picture-in-picture/request-picture-in-picture is split
to work around a flaky timeout in WPT upstream that's related to
#10398

Note: based on #11329

Bug: 806249
Change-Id: I6185253dfa4aae5111e87553581b8464032558d1
Reviewed-on: https://chromium-review.googlesource.com/1107626
Reviewed-by: Robert Ma <robertma@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/master@{#576804}
chromium-wpt-export-bot added a commit that referenced this issue Jul 20, 2018
This makes sure web platform tests for Picture-in-Picture do not time
out when Picture-in-Picture API is not available.

Besides, wpt/picture-in-picture/request-picture-in-picture is split
to work around a flaky timeout in WPT upstream that's related to
#10398

Note: based on #11329

Bug: 806249
Change-Id: I6185253dfa4aae5111e87553581b8464032558d1
Reviewed-on: https://chromium-review.googlesource.com/1107626
Reviewed-by: Robert Ma <robertma@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/master@{#576804}
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Jul 29, 2018
…sts that time out., a=testonly

Automatic update from web-platform-tests[Picture-in-Picture] Fix web platform tests that time out.

This makes sure web platform tests for Picture-in-Picture do not time
out when Picture-in-Picture API is not available.

Besides, wpt/picture-in-picture/request-picture-in-picture is split
to work around a flaky timeout in WPT upstream that's related to
web-platform-tests/wpt#10398

Note: based on web-platform-tests/wpt#11329

Bug: 806249
Change-Id: I6185253dfa4aae5111e87553581b8464032558d1
Reviewed-on: https://chromium-review.googlesource.com/1107626
Reviewed-by: Robert Ma <robertma@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/master@{#576804}

--

wpt-commits: 38ef6aad13a38e3dec8ca2c3783f9ab0575ad356
wpt-pr: 11589
jankeromnes pushed a commit to jankeromnes/gecko that referenced this issue Jul 30, 2018
…sts that time out., a=testonly

Automatic update from web-platform-tests[Picture-in-Picture] Fix web platform tests that time out.

This makes sure web platform tests for Picture-in-Picture do not time
out when Picture-in-Picture API is not available.

Besides, wpt/picture-in-picture/request-picture-in-picture is split
to work around a flaky timeout in WPT upstream that's related to
web-platform-tests/wpt#10398

Note: based on web-platform-tests/wpt#11329

Bug: 806249
Change-Id: I6185253dfa4aae5111e87553581b8464032558d1
Reviewed-on: https://chromium-review.googlesource.com/1107626
Reviewed-by: Robert Ma <robertma@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/master@{#576804}

--

wpt-commits: 38ef6aad13a38e3dec8ca2c3783f9ab0575ad356
wpt-pr: 11589
@foolip foolip mentioned this issue Oct 5, 2018
2 of 4 tasks complete
@foolip

This comment has been minimized.

Copy link
Contributor

@foolip foolip commented Oct 5, 2018

I came across this in #12621. It makes it hard to see what's happening, and all that switching back and forth must have effects that may interfere with the tests. It's also the reason for #7281.

@gsnedders, I'm wondering if we should bump the priority of this to "real soon now" and perhaps do together with #13183. Can you describe what it would take to change this?

@gsnedders

This comment has been minimized.

Copy link
Contributor

@gsnedders gsnedders commented Oct 8, 2018

@foolip We'd need to change how testharness.js tests are run to not run them within a new window (see #12885 (comment)), given WebDriver can only deal with one window at a time. So:

  1. Get rid of the testharness.js parent window (this will involve changing the executors and tools/wptrunner/wptrunner/testharnessreport*)
  2. Change tools/wptrunner/wptrunner/testdriver-extra.js to deal with the current window and not the parent
@jgraham

This comment has been minimized.

Copy link
Contributor

@jgraham jgraham commented Oct 8, 2018

I"m not 100% sure that's necessary. What's undoubtedly required is to stop sending commands to the parent window as the test runs. But it looks like that's possible without merging the windows into one. Maybe I'm missing something though.

@gsnedders

This comment has been minimized.

Copy link
Contributor

@gsnedders gsnedders commented Oct 8, 2018

@jgraham if we're sending all the messages to the current window, what use does the parent window have?

@foolip

This comment has been minimized.

Copy link
Contributor

@foolip foolip commented Oct 8, 2018

FWIW, if we could just not have the extra window that seems much preferable, since the use of window.open() means that we're not testing plain new tabs, which was a problem in the PR @gsnedders already linked to: #12885

@jgraham

This comment has been minimized.

Copy link
Contributor

@jgraham jgraham commented Oct 8, 2018

Not having the window is possible but it's a larger change than required to fix this, with a different set of tradeoffs.

@gsnedders

This comment has been minimized.

Copy link
Contributor

@gsnedders gsnedders commented Oct 8, 2018

@jgraham the parent window is used to receive the results of the testsuite, which would then need to go to the test window (given WebDriver would be listening to messages on the test window), so why do we still need the parent window?

@gsnedders

This comment has been minimized.

Copy link
Contributor

@gsnedders gsnedders commented Oct 8, 2018

@jgraham responded to the above question at https://w3.logbot.info/testing/20181008#c446175

@mdittmer

This comment has been minimized.

Copy link
Contributor

@mdittmer mdittmer commented Dec 12, 2018

Ping from your friendly neighbourhood ecosystem infra rotation

If this is priority:roadmap should it have an assignee?

@foolip

This comment has been minimized.

Copy link
Contributor

@foolip foolip commented Dec 12, 2018

This was fixed by #13419

@foolip foolip closed this Dec 12, 2018
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Oct 3, 2019
…sts that time out., a=testonly

Automatic update from web-platform-tests[Picture-in-Picture] Fix web platform tests that time out.

This makes sure web platform tests for Picture-in-Picture do not time
out when Picture-in-Picture API is not available.

Besides, wpt/picture-in-picture/request-picture-in-picture is split
to work around a flaky timeout in WPT upstream that's related to
web-platform-tests/wpt#10398

Note: based on web-platform-tests/wpt#11329

Bug: 806249
Change-Id: I6185253dfa4aae5111e87553581b8464032558d1
Reviewed-on: https://chromium-review.googlesource.com/1107626
Reviewed-by: Robert Ma <robertmachromium.org>
Reviewed-by: Mounir Lamouri <mlamourichromium.org>
Commit-Queue: François Beaufort <beaufort.francoisgmail.com>
Cr-Commit-Position: refs/heads/master{#576804}

--

wpt-commits: 38ef6aad13a38e3dec8ca2c3783f9ab0575ad356
wpt-pr: 11589

UltraBlame original commit: 071bd4d29886a18128df2ce2dd60f4e150703838
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Oct 3, 2019
…sts that time out., a=testonly

Automatic update from web-platform-tests[Picture-in-Picture] Fix web platform tests that time out.

This makes sure web platform tests for Picture-in-Picture do not time
out when Picture-in-Picture API is not available.

Besides, wpt/picture-in-picture/request-picture-in-picture is split
to work around a flaky timeout in WPT upstream that's related to
web-platform-tests/wpt#10398

Note: based on web-platform-tests/wpt#11329

Bug: 806249
Change-Id: I6185253dfa4aae5111e87553581b8464032558d1
Reviewed-on: https://chromium-review.googlesource.com/1107626
Reviewed-by: Robert Ma <robertmachromium.org>
Reviewed-by: Mounir Lamouri <mlamourichromium.org>
Commit-Queue: François Beaufort <beaufort.francoisgmail.com>
Cr-Commit-Position: refs/heads/master{#576804}

--

wpt-commits: 38ef6aad13a38e3dec8ca2c3783f9ab0575ad356
wpt-pr: 11589

UltraBlame original commit: 071bd4d29886a18128df2ce2dd60f4e150703838
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Oct 3, 2019
…sts that time out., a=testonly

Automatic update from web-platform-tests[Picture-in-Picture] Fix web platform tests that time out.

This makes sure web platform tests for Picture-in-Picture do not time
out when Picture-in-Picture API is not available.

Besides, wpt/picture-in-picture/request-picture-in-picture is split
to work around a flaky timeout in WPT upstream that's related to
web-platform-tests/wpt#10398

Note: based on web-platform-tests/wpt#11329

Bug: 806249
Change-Id: I6185253dfa4aae5111e87553581b8464032558d1
Reviewed-on: https://chromium-review.googlesource.com/1107626
Reviewed-by: Robert Ma <robertmachromium.org>
Reviewed-by: Mounir Lamouri <mlamourichromium.org>
Commit-Queue: François Beaufort <beaufort.francoisgmail.com>
Cr-Commit-Position: refs/heads/master{#576804}

--

wpt-commits: 38ef6aad13a38e3dec8ca2c3783f9ab0575ad356
wpt-pr: 11589

UltraBlame original commit: 071bd4d29886a18128df2ce2dd60f4e150703838
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.