Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document why there is a path length limit or lift it #15355

Closed
annevk opened this issue Feb 12, 2019 · 6 comments
Closed

Document why there is a path length limit or lift it #15355

annevk opened this issue Feb 12, 2019 · 6 comments

Comments

@annevk
Copy link
Member

@annevk annevk commented Feb 12, 2019

It's very easy to hit in html/.

@annevk annevk added the infra label Feb 12, 2019
@gsnedders gsnedders added the docs label Feb 12, 2019
@gsnedders
Copy link
Contributor

@gsnedders gsnedders commented Feb 12, 2019

@jgraham can you remember if we actually hit this in mozilla-central at some point? do you know if it's still the case that it's a problem? like, can we just make sure we prefix everything with \\?\ and use absolute paths for everything?

(cc @thejohnjansen)

@jgraham
Copy link
Contributor

@jgraham jgraham commented Feb 12, 2019

In the past it was the case that third party tools like mercurial and zip didn't support >255 characters, so even if we prefix everything with \\?\ then other parts of the infrastructure would break. So I don't think there's much we can do here unless the Windows situation in all the environments we intend to support has markedly improved in the last 4 years.

@jgraham
Copy link
Contributor

@jgraham jgraham commented Feb 12, 2019

Oh and for clarity, yes this was a real problem that blocked running wpt in m-c until it was fixed.

@LukeZielinski
Copy link
Contributor

@LukeZielinski LukeZielinski commented Feb 20, 2019

Triage: so it sounds like lifting the limit is unlikely, but documenting the reasons still makes sense. Adding backlog priority.

@jugglinmike
Copy link
Contributor

@jugglinmike jugglinmike commented Aug 14, 2019

The docs already explain the rationale:

Due to path length limitations on Windows, test paths must be less that 150 characters relative to the test root directory (this gives vendors just over 100 characters for their own paths when running in automation).

I'm not sure how to proceed since this explanation was present at the time this issue was filed. Normally, this would be a sign that the information is too hard to find, but it's already pretty central: the "File Path and Names" section of the "General Test Guidelines" page.

That page is hierarchically "below" the "Writing Tests" page, so we could move the information up, but I personally don't think this consideration is essential enough to warrant such a promotion.

@annevk do you have thoughts about how we can make this easier to find?

@annevk
Copy link
Member Author

@annevk annevk commented Aug 15, 2019

Nah, let's close this then.

@annevk annevk closed this Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.