Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure Pipelines scheduled triggers need to be migrated to YAML #17342

Closed
foolip opened this issue Jun 14, 2019 · 9 comments
Closed

Azure Pipelines scheduled triggers need to be migrated to YAML #17342

foolip opened this issue Jun 14, 2019 · 9 comments
Assignees

Comments

@foolip
Copy link
Member

@foolip foolip commented Jun 14, 2019

Looking at triggers in the pipeline editor today I see this:
image

You can no longer define scheduled triggers in the editor. Instead, you must add schedules to your YAML file. For more information, see https://go.microsoft.com/fwlink/?linkid=2080841

However, the link leads to https://docs.microsoft.com/en-us/azure/devops/pipelines/yaml-schema?view=azure-devops&tabs=schema and I can't see any documentation on how to migrate the schedule triggers to YAML.

@mustjab @thejohnjansen could you ask if this already works but isn't documented, or what we should do?

It appears that the scheduled runs are still getting triggered, but this could turn urgent if at any point they stop working, since the workaround before has been to make an edit and save them again.

@foolip foolip self-assigned this Jun 14, 2019
@foolip foolip added this to To do in Azure Pipelines via automation Jun 14, 2019
@foolip
Copy link
Member Author

@foolip foolip commented Jun 14, 2019

https://docs.microsoft.com/en-us/azure/devops/pipelines/build/triggers?tabs=yaml&view=azure-devops#scheduled-triggers says:

Scheduled builds are not yet supported in YAML syntax. After you create your YAML build pipeline, you can use pipeline settings to specify a scheduled trigger.

Hopefully this isn't true :)

@foolip
Copy link
Member Author

@foolip foolip commented Aug 15, 2019

foolip added a commit that referenced this issue Aug 15, 2019
Based on another migration which worked:
foolip/safari-technology-preview-updater@259eff3

Fixes #17342.
@foolip
Copy link
Member Author

@foolip foolip commented Aug 15, 2019

I've sent #18442, and when I went to remove the triggers in the screenshot at the top of this issue, I found they weren't there, not even in a disabled state. @thejohnjansen @mustjab did either of you remove them while trying to debug #18397? It doesn't matter since they'll be replaced, but it is odd because in my safari-technology-preview-updater repo I had to remove them manually.

Azure Pipelines automation moved this from To do to Done Aug 15, 2019
foolip added a commit that referenced this issue Aug 15, 2019
Based on another migration which worked:
foolip/safari-technology-preview-updater@259eff3

Fixes #17342.
@foolip
Copy link
Member Author

@foolip foolip commented Aug 15, 2019

#18442 didn't work, a build should have been triggered 06:15 UTC (15 minutes ago) but wasn't.

@foolip foolip reopened this Aug 15, 2019
Azure Pipelines automation moved this from Done to In progress Aug 15, 2019
@foolip
Copy link
Member Author

@foolip foolip commented Aug 15, 2019

Since the trigger originally configured in the Azure DevOps UI are no longer there, fixing this has become urgent :(

@foolip
Copy link
Member Author

@foolip foolip commented Aug 15, 2019

There's some chance the reason it didn't work was because the epochs/six_hourly branch wasn't updated in time. The configuration was on master, but locally I didn't see the epochs/six_hourly ref update a bit after 06:00, and looking at webhook activity it looks like it might have been updated at 06:32.

Waiting for another 6 hours to see if the next one will be triggered.

@foolip
Copy link
Member Author

@foolip foolip commented Aug 15, 2019

(The possible reason being that if the configuration isn't on the branch being triggered, it doesn't work.)

@foolip
Copy link
Member Author

@foolip foolip commented Aug 15, 2019

To verify that the configuration is working at all currently I've triggered a manual build for Edge Dev, Edge Canary, Safari and Safari Technology Preview: https://dev.azure.com/web-platform-tests/wpt/_build/results?buildId=27211

@foolip
Copy link
Member Author

@foolip foolip commented Aug 15, 2019

@foolip foolip closed this Aug 15, 2019
foolip added a commit that referenced this issue Aug 16, 2019
…18445)

As it is, it's only possible to run both of them:
#17342 (comment)

This also renames the Edge Dev job and artifacts so that Edge stable can
later be added without further renaming.
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Aug 23, 2019
…ds to YAML, a=testonly

Automatic update from web-platform-tests
[Azure Pipelines] Migrate scheduled builds to YAML (#18442)

Based on another migration which worked:
foolip/safari-technology-preview-updater@259eff3

Fixes web-platform-tests/wpt#17342.
--

wpt-commits: b16bc5597bb9981c3bd29ca3209979df0c9c24fe
wpt-pr: 18442
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Aug 23, 2019
…riggers for Edge Dev/Canary, a=testonly

Automatic update from web-platform-tests
[Azure Pipelines] Differentiate manual triggers for Edge Dev/Canary (#18445)

As it is, it's only possible to run both of them:
web-platform-tests/wpt#17342 (comment)

This also renames the Edge Dev job and artifacts so that Edge stable can
later be added without further renaming.

--

wpt-commits: c1e89362cb351be0ea9239e38cf5830e104ba1f4
wpt-pr: 18445
xeonchen pushed a commit to xeonchen/gecko that referenced this issue Aug 23, 2019
…ds to YAML, a=testonly

Automatic update from web-platform-tests
[Azure Pipelines] Migrate scheduled builds to YAML (#18442)

Based on another migration which worked:
foolip/safari-technology-preview-updater@259eff3

Fixes web-platform-tests/wpt#17342.
--

wpt-commits: b16bc5597bb9981c3bd29ca3209979df0c9c24fe
wpt-pr: 18442
xeonchen pushed a commit to xeonchen/gecko that referenced this issue Aug 23, 2019
…riggers for Edge Dev/Canary, a=testonly

Automatic update from web-platform-tests
[Azure Pipelines] Differentiate manual triggers for Edge Dev/Canary (#18445)

As it is, it's only possible to run both of them:
web-platform-tests/wpt#17342 (comment)

This also renames the Edge Dev job and artifacts so that Edge stable can
later be added without further renaming.

--

wpt-commits: c1e89362cb351be0ea9239e38cf5830e104ba1f4
wpt-pr: 18445
natechapin added a commit to natechapin/wpt that referenced this issue Aug 23, 2019
…eb-platform-tests#18445)

As it is, it's only possible to run both of them:
web-platform-tests#17342 (comment)

This also renames the Edge Dev job and artifacts so that Edge stable can
later be added without further renaming.
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Oct 4, 2019
…ds to YAML, a=testonly

Automatic update from web-platform-tests
[Azure Pipelines] Migrate scheduled builds to YAML (#18442)

Based on another migration which worked:
foolip/safari-technology-preview-updater@259eff3

Fixes web-platform-tests/wpt#17342.
--

wpt-commits: b16bc5597bb9981c3bd29ca3209979df0c9c24fe
wpt-pr: 18442

UltraBlame original commit: d3ff9a191f89e8fcdc40fbd7b574be12eb06228a
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Oct 4, 2019
…riggers for Edge Dev/Canary, a=testonly

Automatic update from web-platform-tests
[Azure Pipelines] Differentiate manual triggers for Edge Dev/Canary (#18445)

As it is, it's only possible to run both of them:
web-platform-tests/wpt#17342 (comment)

This also renames the Edge Dev job and artifacts so that Edge stable can
later be added without further renaming.

--

wpt-commits: c1e89362cb351be0ea9239e38cf5830e104ba1f4
wpt-pr: 18445

UltraBlame original commit: 097066d228b2fbe5da8346271578e3ed36566697
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Oct 4, 2019
…ds to YAML, a=testonly

Automatic update from web-platform-tests
[Azure Pipelines] Migrate scheduled builds to YAML (#18442)

Based on another migration which worked:
foolip/safari-technology-preview-updater@259eff3

Fixes web-platform-tests/wpt#17342.
--

wpt-commits: b16bc5597bb9981c3bd29ca3209979df0c9c24fe
wpt-pr: 18442

UltraBlame original commit: d3ff9a191f89e8fcdc40fbd7b574be12eb06228a
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Oct 4, 2019
…riggers for Edge Dev/Canary, a=testonly

Automatic update from web-platform-tests
[Azure Pipelines] Differentiate manual triggers for Edge Dev/Canary (#18445)

As it is, it's only possible to run both of them:
web-platform-tests/wpt#17342 (comment)

This also renames the Edge Dev job and artifacts so that Edge stable can
later be added without further renaming.

--

wpt-commits: c1e89362cb351be0ea9239e38cf5830e104ba1f4
wpt-pr: 18445

UltraBlame original commit: 097066d228b2fbe5da8346271578e3ed36566697
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Oct 4, 2019
…ds to YAML, a=testonly

Automatic update from web-platform-tests
[Azure Pipelines] Migrate scheduled builds to YAML (#18442)

Based on another migration which worked:
foolip/safari-technology-preview-updater@259eff3

Fixes web-platform-tests/wpt#17342.
--

wpt-commits: b16bc5597bb9981c3bd29ca3209979df0c9c24fe
wpt-pr: 18442

UltraBlame original commit: d3ff9a191f89e8fcdc40fbd7b574be12eb06228a
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Oct 4, 2019
…riggers for Edge Dev/Canary, a=testonly

Automatic update from web-platform-tests
[Azure Pipelines] Differentiate manual triggers for Edge Dev/Canary (#18445)

As it is, it's only possible to run both of them:
web-platform-tests/wpt#17342 (comment)

This also renames the Edge Dev job and artifacts so that Edge stable can
later be added without further renaming.

--

wpt-commits: c1e89362cb351be0ea9239e38cf5830e104ba1f4
wpt-pr: 18445

UltraBlame original commit: 097066d228b2fbe5da8346271578e3ed36566697
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Azure Pipelines
  
In progress
Linked pull requests

Successfully merging a pull request may close this issue.

1 participant
You can’t perform that action at this time.