Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window resize fails in Chrome Android #18465

Open
lukebjerring opened this issue Aug 15, 2019 · 4 comments
Open

Window resize fails in Chrome Android #18465

lukebjerring opened this issue Aug 15, 2019 · 4 comments

Comments

@lukebjerring
Copy link
Contributor

@lukebjerring lukebjerring commented Aug 15, 2019

Right now, reftests aren't working for Chrome android because there's no concept of resizing the window.

We should at least either either ignore or work around this issue, possibly by hacking in a zoom modification in lieu of the ability to resize the window itself? @Hexcles
While the required window size isn't met by android, we'd still get some value from being able to produce the screenshots.

Possibly related to #8571, though we don't have infra coverage for Android anyway.

@Hexcles Hexcles added the infra label Aug 15, 2019
@Hexcles
Copy link
Member

@Hexcles Hexcles commented Aug 15, 2019

There's no way to resize a window on Android, but we most likely need to reset the zoom level to 100% to make sure the screenshots are meaningful, comparable and stable. However, it seems like WebDriver specs has no mentioning of zoom level.

I'm looking at document.body.style.zoom, which is unfortunately a Blink/WebKit-only API but perhaps can be justified to use here.

Also related to #7598 #12725

@jgraham
Copy link
Contributor

@jgraham jgraham commented Aug 16, 2019

Zoom could and should be easily added to WebDriver.

Note that running reftests on mobile has some interesting challenges. For example you need to ensure that the device pixel ratio is set to 1, even though phones usually have a very different value. Getting the viewport to be the expected size is also a problem. Gecko basically has some special settings that afiak are only used for reftests that allow creating a document with the correct size and getting a screenshot of the full document independent of the actual device size.

@foolip
Copy link
Member

@foolip foolip commented Aug 19, 2019

@lukebjerring set to backlog priority, but maybe should be higher if it's blocking Android runs?

@Hexcles
Copy link
Member

@Hexcles Hexcles commented Aug 19, 2019

We can easily bypass reftests on Android for now. The question is how much value we can get out of reftests on Android.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.