Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write Tests for Image-Orientation Initial Value #18549

Open
nomadtechie opened this issue Aug 19, 2019 · 3 comments
Open

Write Tests for Image-Orientation Initial Value #18549

nomadtechie opened this issue Aug 19, 2019 · 3 comments

Comments

@nomadtechie
Copy link
Member

@nomadtechie nomadtechie commented Aug 19, 2019

The CSS Spec has been recently updated to interpret EXIF values from images by default. See discussion and patch here w3c/csswg-drafts#3799

@nomadtechie nomadtechie self-assigned this Aug 19, 2019
@nomadtechie

This comment has been minimized.

Copy link
Member Author

@nomadtechie nomadtechie commented Aug 19, 2019

@zcorpan

This comment has been minimized.

Copy link
Member

@zcorpan zcorpan commented Aug 19, 2019

In https://github.com/web-platform-tests/wpt/tree/master/css/css-images there are some tests already for image-orientation (in particular inheritance.html and in parsing/ )

Per w3c/csswg-drafts#4165 (comment) it's possible that the image-orientation CSS property may be dropped altogether, so we probably shouldn't spend too much time right now on fully testing the CSS property itself. But testing the change of the initial value is easy (1 line change in inheritance.html).

The different cases on the web that can show an image, that seem interesting to test (without any 'image-orientation' specified, with an image with some EXIF rotation):

  • CSS
    • ::before/::after + content
    • background-image
    • list-style-image
    • border-image
    • cursor
  • SVG
    • image
  • HTML
    • img
    • canvas drawImage() + getImageData()
    • video poster
    • input type=image
    • embed
    • object
  • load an image in an iframe
  • load an image in a top-level doc (this already respects EXIF in all browsers I believe)
  • Favicon link rel=icon / favicon.ico (manual tests?)
  • web app manifest icon (manual test?)

There might be some other place on the web platform that displays images, but this covers almost everything I think, and also we don't need to test everything in the first patch. 😊

@noell

This comment has been minimized.

Copy link

@noell noell commented Aug 29, 2019

Images for testing purposes https://github.com/noell/jpg-exif-test-images

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.