Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restart Safari after timeout/error #19620

Open
gsnedders opened this issue Oct 10, 2019 · 4 comments
Open

Restart Safari after timeout/error #19620

gsnedders opened this issue Oct 10, 2019 · 4 comments

Comments

@gsnedders
Copy link
Contributor

@gsnedders gsnedders commented Oct 10, 2019

At the moment we fail to even send delete session if the HTTP client has hung because httplib fails to send it because it's already waiting on a response. We should do better.

@foolip
Copy link
Member

@foolip foolip commented Oct 14, 2019

This should resolve #18634 and #18635.

@foolip foolip closed this Nov 21, 2019
Reliable Safari results automation moved this from To do to Done Nov 21, 2019
@foolip foolip reopened this Nov 21, 2019
Reliable Safari results automation moved this from Done to To do Nov 21, 2019
@foolip
Copy link
Member

@foolip foolip commented Dec 20, 2019

This might have avoided #20878, where we failed after "CRITICAL Max restarts exceeded".

@foolip
Copy link
Member

@foolip foolip commented Dec 20, 2019

Yep, #20878 (comment) looks like this issue, "Could not create a session: The Safari instance is already paired with another WebDriver session."

@gsnedders
Copy link
Contributor Author

@gsnedders gsnedders commented Jan 31, 2020

Likely would also resolve #18995.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.