Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
Request reviews of baseline tests for `vertical-lr` #21124
As far as I reviewed, the reference files for these tests need to fix:
A bit of background:
@fantasai Do you remember, or could you review again?
I don't know Hajime and Gerard's github account, I'll send e-mail to them.
Hello Koji and Hajime :)
I see nothing wrong with those 5 tests and 3 reference files.
I think that these tests are correct.
These tests are for 'vertical-lr'.
Do you think that these tests are correct now?
Thank you for taking a look, Hajime and Gerard. I think this was a false alarm, sorry for the noise.
I think my memory is coming back -- @fantasai and I reviewed them because there were no impls that pass, and concluded tests are correct. That might be why we didn't take any actions after the review.
Issue 664386: Baselines of inline-block and inline-table do not respect the last line box or the first row if 'writing-mode' is 'vertical-lr'.
Bug 1179952: Baseline alignment of inline-block and inline-table when dominant baseline is central