Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_verify_taskcluster_yml fails on Windows in Python 3 #24561

Closed
Hexcles opened this issue Jul 10, 2020 · 3 comments
Closed

test_verify_taskcluster_yml fails on Windows in Python 3 #24561

Hexcles opened this issue Jul 10, 2020 · 3 comments

Comments

@Hexcles
Copy link
Member Author

@Hexcles Hexcles commented Jul 10, 2020

Maybe relevant: pyexcel/pyexcel#180

Hexcles added a commit that referenced this issue Jul 10, 2020
See #24561 for details.
Hexcles added a commit that referenced this issue Jul 10, 2020
See #24561 for details.
Hexcles added a commit that referenced this issue Jul 10, 2020
* [lint] Fix a type annotation

This was introduced in #24520 accidentally.

* Skip quic in pytest and coverage

quic/ contains Python 3-only code that leads to warnings when running
`pytest --cov` in Python 2.

* Mark a test as expected to fail on Windows+py3

See #24561 for details.

* Drive-by: change docker-worker schema URL
@stephenmcgruer
Copy link
Contributor

@stephenmcgruer stephenmcgruer commented Jul 30, 2020

I'm not sure I'm reading the logs right, but it looks like this caused a fail in https://dev.azure.com/web-platform-tests/wpt/_build/results?buildId=51916&view=logs&j=85f2ffec-1d6e-5253-c3dd-62d5cd43e221&t=a9a637ac-afdf-5c9e-e3a0-6b959a0fc833, which shouldn't happen because its XPASS?

The step failed, and this is the only test failure I see. There is also this, but not clear what it's caused by:

2020-07-30T10:47:30.2165403Z ERROR: InvocationError for command 'D:\a\1\s\tools\.tox\py38\Scripts\pytest.EXE' --cov=tools --cov-report=term --junitxml=results.xml (exited with code 1)

@Hexcles
Copy link
Member Author

@Hexcles Hexcles commented Jul 30, 2020

Great! XPASS means "unexpected passing". Perhaps one of the underlying dependency has upgraded and the issue now goes away. This is also why I prefer XFAIL over SKIP.

The last error you saw simply meant the pytest command failed, because of the unexpected pass.

Hexcles added a commit that referenced this issue Jul 30, 2020
The test has started passing recently.

Fixes #24561
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.