Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parts of canvas tests relating to generating an annotated spec should be removed #26618

Closed
adroitwhiz opened this issue Nov 23, 2020 · 0 comments
Closed

Comments

@adroitwhiz
Copy link
Contributor

@adroitwhiz adroitwhiz commented Nov 23, 2020

Previously, running the canvas tests' build.sh generated an annotated version of the HTML canvas spec.

This functionality has been removed in dadd085, but some cruft has been left behind:

  • html/canvas/tools/current-work-canvas.xhtml, which is a stripped-down version of the canvas spec previously used to generate the annotated version.
  • html/canvas/tools/specextract.py, which generates current-work-canvas.xhtml.
  • Weird syntax in html/canvas/tools/spec.yaml (e.g. <^>, <...>, <eol>), which, as far as I can tell, only exists to aid in the generation of the annotated spec.
  • The previously field, also in spec.yaml, which appears to be unused now.
  • The htmlSerializer and getNodeText functions in html/canvas/tools/gentestutils.py, which was used only to serialize the annotated spec.

These should be removed if possible--I'm trying to write tests for a proposal that modifies a substantial amount of the canvas spec, and having so many supporting changes in place for removed functionality led me down a rabbit hole of confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant