Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The YAML sources for certain canvas tests have disappeared #26647

Open
adroitwhiz opened this issue Nov 25, 2020 · 3 comments · May be fixed by #26650
Open

The YAML sources for certain canvas tests have disappeared #26647

adroitwhiz opened this issue Nov 25, 2020 · 3 comments · May be fixed by #26650
Labels

Comments

@adroitwhiz
Copy link
Contributor

@adroitwhiz adroitwhiz commented Nov 25, 2020

PR #24099 seems to have accidentally removed the YAML sources used to generate some canvas tests.

For instance, the canvas element's initial.reset.same test is no longer defined in any YAML files (note that the corresponding offscreen-canvas test is still present).

I have no idea which tests specifically have been removed or how many, but they should be re-added.

@stephenmcgruer
Copy link
Contributor

@stephenmcgruer stephenmcgruer commented Nov 25, 2020

@stephenmcgruer stephenmcgruer added the html label Nov 25, 2020
@adroitwhiz
Copy link
Contributor Author

@adroitwhiz adroitwhiz commented Nov 25, 2020

It looks like most/all of the tests previously defined in tests.yaml are missing. From what I can see, the script used to split up tests.yaml and tests2d.yaml first processes tests.yaml then overwrites the output with that of tests2d.yaml.

As an example:

  • Some items in tests.yaml are split and written into the-canvas-element.yaml
  • Some items in tests2d.yaml are split and also written into the-canvas-element.yaml
  • Instead of combining the two, the items from tests2d.yaml completely overwrite the the-canvas-element.yaml file

This seems to have happened for all the "categorized" .yaml files.

This only affects the-canvas-element.yaml, because all the tests in tests.yaml were categorized into the-canvas-element.

@adroitwhiz adroitwhiz linked a pull request that will close this issue Nov 25, 2020
@mysteryDate
Copy link
Contributor

@mysteryDate mysteryDate commented Nov 27, 2020

Interesting, good catch @adroitwhiz, I gave a hack at splitting up the huge yaml files back in June:

https://chromium-review.googlesource.com/c/chromium/src/+/2240038

It was so much grunt work that I automated it with a script, I clearly missed something. Thanks for fixing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants