New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
responsexml-document-properties.htm does not seem supported by specs #2668
Comments
Hm..I think I asked around for opinions, not sure if I heard back from @annevk or not and I won't spend time looking up E-mails. (I was at Opera back then anyway, don't have that mailbox anymore so it might simply be lost). I think the conclusion back then was along the lines of "assert what a few browers seem to have converged on, we'll get to standardising this later". The history of the test and why it's written like that isn't important, what it should be asserting is. I'd be open to arguments that this is a test suite for XHR and we should refrain from testing stuff that really belongs elsewhere, like the properties defined on a Document or XMLDocument - if you @domenic will argue we should simplify the test and drop all assertations for document properties I can agree that would make some sense. It's still somewhat useful to check what interface/prototype browsers use for xhr.responseXML documents - coding suggestions welcome. |
I think we should assert those properties, we should just make them assert the correct values. Which e.g., for |
We should first sort whatwg/dom#221 before we can fix this. |
…nt. r=mystor The "body" part of responsexml-document-properties.htm is not really per current spec text, and fails in every non-Firefox browser, and in Firefox after this change. web-platform-tests/wpt#2668 tracks this issue to some extent, but if all browsers are going to align here anyway, we should just adjust the test and move on. MozReview-Commit-ID: HTLfggvi5LL
The "body" part of responsexml-document-properties.htm is not really per current spec text, and fails in every non-Firefox browser, and in Firefox after this change. #2668 tracks this issue to some extent, but if all browsers are going to align here anyway, we should just adjust the test and move on. MozReview-Commit-ID: HTLfggvi5LL Upstreamed from https://bugzilla.mozilla.org/show_bug.cgi?id=1276438 [ci skip]
…nt. r=mystor The "body" part of responsexml-document-properties.htm is not really per current spec text, and fails in every non-Firefox browser, and in Firefox after this change. web-platform-tests/wpt#2668 tracks this issue to some extent, but if all browsers are going to align here anyway, we should just adjust the test and move on. MozReview-Commit-ID: HTLfggvi5LL UltraBlame original commit: d6b890b102b7197415317b0966e6a5c636fd5f57
…nt. r=mystor The "body" part of responsexml-document-properties.htm is not really per current spec text, and fails in every non-Firefox browser, and in Firefox after this change. web-platform-tests/wpt#2668 tracks this issue to some extent, but if all browsers are going to align here anyway, we should just adjust the test and move on. MozReview-Commit-ID: HTLfggvi5LL UltraBlame original commit: d6b890b102b7197415317b0966e6a5c636fd5f57
…nt. r=mystor The "body" part of responsexml-document-properties.htm is not really per current spec text, and fails in every non-Firefox browser, and in Firefox after this change. web-platform-tests/wpt#2668 tracks this issue to some extent, but if all browsers are going to align here anyway, we should just adjust the test and move on. MozReview-Commit-ID: HTLfggvi5LL UltraBlame original commit: d6b890b102b7197415317b0966e6a5c636fd5f57
https://github.com/w3c/web-platform-tests/blob/master/XMLHttpRequest/responsexml-document-properties.htm
No existing specs state that documents returned from XHRs should have a bunch of undefined properties. What's the deal? @annevk @hallvors
The text was updated successfully, but these errors were encountered: