Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have a single test to test bidi session with different capabilities #27808

Open
k7z45 opened this issue Feb 26, 2021 · 0 comments
Open

Have a single test to test bidi session with different capabilities #27808

k7z45 opened this issue Feb 26, 2021 · 0 comments

Comments

@k7z45
Copy link
Contributor

@k7z45 k7z45 commented Feb 26, 2021

Posted by @whimboo #27687 (comment)
As mentioned in my reviews for the initial PR (and what @jgraham also referred to earlier in this PR) lets get an issue filed so we can make sure to have a single test for that. It would most likely need the new_session fixture, or maybe a new one for BiDiSession.

Originally posted by @whimboo in #27195 (comment)
[3] We might need a similar new_session fixture for BiDi so that you can create multiple new sessions with different capabilities within a single test.

Also, by @jgraham
The main part of this looks reasonable. I'm somewhat nervous about all the tests that are basically testing the infrastructure itself and depend on everything running in source order.
#27734 (review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants