New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eme] Migrate remaining Google tests to main framework #3583

Closed
mwatson2 opened this Issue Aug 25, 2016 · 26 comments

Comments

Projects
None yet
5 participants
@mwatson2
Contributor

mwatson2 commented Aug 25, 2016

The following are in need of migration. Please reply to this issue to claim some:

  • encrypted-media-clear-key-invalid-license.html
  • encrypted-media-clearkey-update-non-ascii-input.html
  • encrypted-media-keystatuses-multiple-sessions.html
  • encrypted-media-keystatuses-multiple-updates.html
  • encrypted-media-onencrypted.html
  • encrypted-media-playback-encrypted-and-clear-sources.html
  • encrypted-media-playback-multiple-sessions.html
  • encrypted-media-requestmediakeysystemaccess.html
  • encrypted-media-reset-src-after-setmediakeys.html
  • encrypted-media-session-closed-event.html
  • encrypted-media-setmediakeys-again-after-playback.html
  • encrypted-media-setmediakeys-again-after-resetting-src.html
  • encrypted-media-setmediakeys-at-same-time.html
  • encrypted-media-setmediakeys-multiple-times-with-different-mediakeys.html
  • encrypted-media-setmediakeys-multiple-times-with-the-same-mediakeys.html
  • encrypted-media-setmediakeys-to-multiple-video-elements.html
  • encrypted-media-setmediakeys.html
  • encrypted-media-syntax.html
  • encrypted-media-unique-origin.html
  • encrypted-media-update-disallowed-input.html
  • encrypted-media-waiting-for-a-key.html
@sukhmal

This comment has been minimized.

Contributor

sukhmal commented Aug 29, 2016

I will start off by migrating setmediakeys tests:

  • encrypted-media-setmediakeys-again-after-playback.html
  • encrypted-media-setmediakeys-again-after-resetting-src.html
  • encrypted-media-setmediakeys-at-same-time.html
  • encrypted-media-setmediakeys-multiple-times-with-different-mediakeys.html
  • encrypted-media-setmediakeys-multiple-times-with-the-same-mediakeys.html
  • encrypted-media-setmediakeys-to-multiple-video-elements.html
  • encrypted-media-setmediakeys.html
@jdsmith3000

This comment has been minimized.

Contributor

jdsmith3000 commented Aug 30, 2016

These then are remaining for someone to migrate:

  • encrypted-media-clear-key-invalid-license.html
  • encrypted-media-clearkey-update-non-ascii-input.html
  • encrypted-media-keystatuses-multiple-sessions.html
  • encrypted-media-keystatuses-multiple-updates.html
  • encrypted-media-onencrypted.html
  • encrypted-media-playback-encrypted-and-clear-sources.html
  • encrypted-media-playback-multiple-sessions.html
  • encrypted-media-requestmediakeysystemaccess.html
  • encrypted-media-reset-src-after-setmediakeys.html
  • encrypted-media-session-closed-event.html
  • encrypted-media-syntax.html
  • encrypted-media-unique-origin.html
  • encrypted-media-update-disallowed-input.html
  • encrypted-media-waiting-for-a-key.html
@mwatson2

This comment has been minimized.

Contributor

mwatson2 commented Sep 15, 2016

I will look at:

  • encrypted-media-keystatuses-multiple-sessions.html
  • encrypted-media-keystatuses-multiple-updates.html
@mwatson2

This comment has been minimized.

Contributor

mwatson2 commented Sep 15, 2016

Actually, encrypted-media-keystatuses-multiple-sessions.html has already been done.

@mwatson2

This comment has been minimized.

Contributor

mwatson2 commented Sep 15, 2016

encrypted-media-keystatuses-multiple-updates.html tests that a single clearkey session can receive two update() calls each adding a single key, after only a single license-request message has been generated.

I don't believe any of the DRMs support this flow.

So, then I would propose that we do not need to migrate this test (see #3737)

@mwatson2

This comment has been minimized.

Contributor

mwatson2 commented Sep 15, 2016

I will look at:

  • encrypted-media-playback-encrypted-and-clear-sources.html
  • encrypted-media-playback-multiple-sessions.html
@ddorwin

This comment has been minimized.

Contributor

ddorwin commented Sep 15, 2016

Regarding #3583 (comment), encrypted-media-keystatuses-multiple-updates.html is probably testing that the keys in the session can change. The test cheats a little because it is easy to create a Clear Key license. However, DRMs might support this flow in a (non-continuous) key rotation scenario. Writing that test would require support from the test server.

@mwatson2

This comment has been minimized.

Contributor

mwatson2 commented Sep 15, 2016

@ddorwin Do you mean the keys within a single session ? This is only possible to test if either:
(a) the DRM supports unsolicited provision of new keys (and our server supports creation of such messages), or
(b) the DRM fires new license-request messages itself, which our server can respond to.

I had imagined that one form of key rotation is supported by the DRM triggering a new license-request when the expiration time of its existing keys approaches. Does Widevine support this ? We would need to switch to the JWT authorization approach, since the test dummy approach doesn't give us very short-lived keys.

@ddorwin

This comment has been minimized.

Contributor

ddorwin commented Sep 15, 2016

Yes. I think (b) but with "license-renewal" is the likely scenario. Yes, I believe this is supported.

This isn't a high priority, and I'm fine with deferring this work (to a separate bug and marking the text as done for now). I just wanted to point out that the scenario this test is trying to cover is valid for Key Systems other than Clear Key.

@mwatson2

This comment has been minimized.

Contributor

mwatson2 commented Sep 15, 2016

Ok, I filed #3740

@mwatson2

This comment has been minimized.

Contributor

mwatson2 commented Sep 15, 2016

encrypted-media-playback-encrypted-and-clear-sources.html is addressed by #3739.

I believe encrypted-media-playback-multiple-sessions.html may already be addresed by #3629

@mwatson2

This comment has been minimized.

Contributor

mwatson2 commented Sep 16, 2016

Indeed encrypted-media-playback-multiple-sessions.html is already addressed by #3629 (#3745 to move it).

@mwatson2

This comment has been minimized.

Contributor

mwatson2 commented Sep 16, 2016

I will look at encrypted-media-requestmediakeysystemaccess.html next. The remaining tests to be migrated are:

  • encrypted-media-clear-key-invalid-license.html
  • encrypted-media-clearkey-update-non-ascii-input.html
  • encrypted-media-onencrypted.html
  • encrypted-media-reset-src-after-setmediakeys.html
  • encrypted-media-session-closed-event.html
  • encrypted-media-syntax.html
  • encrypted-media-unique-origin.html
  • encrypted-media-update-disallowed-input.html
  • encrypted-media-waiting-for-a-key.html
@mwatson2

This comment has been minimized.

Contributor

mwatson2 commented Sep 18, 2016

PR #3747 for encrypted-media-requestmediakeysystemaccess.html

sukhmal added a commit to sukhmal/web-platform-tests that referenced this issue Sep 19, 2016

@mwatson2

This comment has been minimized.

Contributor

mwatson2 commented Sep 21, 2016

Stefan Pham (@squapp) is working on:

  • encrypted-media-clear-key-invalid-license.html
  • encrypted-media-clearkey-update-non-ascii-input.html
  • encrypted-media-onencrypted.html
  • encrypted-media-session-closed-event.html
  • encrypted-media-unique-origin.html
@squapp

This comment has been minimized.

Contributor

squapp commented Sep 21, 2016

PR #3790 for

  • encrypted-media-clear-key-invalid-license.html
  • encrypted-media-clearkey-update-non-ascii-input.html
  • encrypted-media-onencrypted.html
  • encrypted-media-unique-origin.html

Working on these next:

  • encrypted-media-waiting-for-a-key.html
  • encrypted-media-reset-src-after-setmediakeys.html
  • encrypted-media-session-closed-event.html
  • encrypted-media-update-disallowed-input.html
@sukhmal

This comment has been minimized.

Contributor

sukhmal commented Sep 22, 2016

PR #3795 for

  • encrypted-media-setmediakeys-again-after-playback.html
  • encrypted-media-setmediakeys-again-after-resetting-src.html
  • encrypted-media-setmediakeys-at-same-time.html
  • encrypted-media-setmediakeys-multiple-times-with-different-mediakeys.html
  • encrypted-media-setmediakeys-multiple-times-with-the-same-mediakeys.html
  • encrypted-media-setmediakeys-to-multiple-video-elements.html
  • encrypted-media-setmediakeys.html
@squapp

This comment has been minimized.

Contributor

squapp commented Sep 22, 2016

PR #3799 for

  • encrypted-media-waiting-for-a-key.html
  • encrypted-media-reset-src-after-setmediakeys.html
  • encrypted-media-session-closed-event.html
  • encrypted-media-update-disallowed-input.html

Next (and last test):

  • encrypted-media-syntax.html
@jdsmith3000

This comment has been minimized.

Contributor

jdsmith3000 commented Sep 27, 2016

Since the last file is in work to be migrated, I'd like to move the remaining Google tests into a disabled subfolder, and comment out the test harness lines so they don't run. Okay?

These files are currently still in the Google folder:

  • encrypted-media-clear-key-invalid-license.html
  • encrypted-media-clearkey-update-non-ascii-input.html
  • encrypted-media-onencrypted.html
  • encrypted-media-reset-src-after-setmediakeys.html
  • encrypted-media-session-closed-event.html
  • encrypted-media-setmediakeys-again-after-playback.html
  • encrypted-media-setmediakeys-again-after-resetting-src.html
  • encrypted-media-setmediakeys-at-same-time.html
  • encrypted-media-setmediakeys-multiple-times-with-different-mediakeys.html
  • encrypted-media-setmediakeys-multiple-times-with-the-same-mediakeys.html
  • encrypted-media-setmediakeys-to-multiple-video-elements.html
  • encrypted-media-setmediakeys.html
  • encrypted-media-syntax.html
  • encrypted-media-unique-origin.html
  • encrypted-media-update-disallowed-input.html
  • encrypted-media-utils.js
  • encrypted-media-waiting-for-a-key.html
@jdsmith3000

This comment has been minimized.

Contributor

jdsmith3000 commented Sep 29, 2016

@mwatson2 @sukhmal Any objections to pulling these now? I believe they only pass on Chrome, and it would be best to focus on the migrated tests now.

@mwatson2

This comment has been minimized.

Contributor

mwatson2 commented Sep 29, 2016

Fine by me to disable them now.

jdsmith3000 added a commit to jdsmith3000/web-platform-tests that referenced this issue Sep 29, 2016

Fixed web-platform-tests#3583: Disabled remaining Google tests
All are either migrated or in process.
@jdsmith3000

This comment has been minimized.

Contributor

jdsmith3000 commented Oct 3, 2016

@squapp I see you are working:

  • encrypted-media-syntax.html

#3846 moves all of the remaining Google tests into the disabled folder and comments out the test harness links so that they no longer run. I plan to merge that change in later today. FYI.

Do have an ETA for this last test?

@jdsmith3000 jdsmith3000 reopened this Oct 3, 2016

@jdsmith3000

This comment has been minimized.

Contributor

jdsmith3000 commented Oct 3, 2016

The Google tests have now all been disabled, but migration work is not yet completed. Re-opening this issue until that is done.

@squapp

This comment has been minimized.

Contributor

squapp commented Oct 4, 2016

@jdsmith3000 encrypted-media-syntax.html will be completed by tomorrow, Wednesday

@squapp

This comment has been minimized.

Contributor

squapp commented Oct 5, 2016

PR #3874 for the last test: encrypted-media-syntax.html

mwatson2 added a commit that referenced this issue Oct 5, 2016

@mwatson2

This comment has been minimized.

Contributor

mwatson2 commented Oct 7, 2016

The last PR for this has been merged.

@mwatson2 mwatson2 closed this Oct 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment