Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for transferring ImageBitmap objects. #10000

Merged
merged 1 commit into from Apr 11, 2018

Conversation

Projects
None yet
4 participants
@Ms2ger
Copy link
Contributor

Ms2ger commented Mar 13, 2018

No description provided.

@wpt-pr-bot

This comment has been minimized.

Copy link
Collaborator

wpt-pr-bot commented Mar 13, 2018

There are no owners for this pull request. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you!

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 13, 2018

Build PASSED

Started: 2018-03-13 16:21:12
Finished: 2018-03-13 16:31:25

View more information about this build on:

@foolip

foolip approved these changes Apr 6, 2018

Copy link
Contributor

foolip left a comment

LGTM % style suggestions for you to do as you please with

for (let { name, factory } of imageSourceTypes) {
promise_test(function(t) {
let message_handler = new Promise(function(resolve) {

This comment has been minimized.

Copy link
@foolip

foolip Apr 6, 2018

Contributor

Can you inline this where it's used, with a comment pointing to what invokes resolve? Having it out of order and the indirection made me scratch my head for a bit.

<script src="common.sub.js"></script>
<div id=log></div>
<script>
let worker, tests = {};

This comment has been minimized.

Copy link
@foolip

foolip Apr 6, 2018

Contributor

Can you rename tests to continuations or something? It's a map from test names to callbacks, not what I thought at first.

@Ms2ger Ms2ger force-pushed the ibm-transfer branch from 70331b3 to ad4489b Apr 11, 2018

@foolip

foolip approved these changes Apr 11, 2018

Copy link
Contributor

foolip left a comment

Thanks, looks great!

@foolip foolip merged commit 5d9948b into master Apr 11, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@foolip foolip deleted the ibm-transfer branch Apr 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.