Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README file for entries-api #10003

Merged
merged 3 commits into from Mar 14, 2018

Conversation

Projects
None yet
5 participants
@inexorabletash
Copy link
Contributor

inexorabletash commented Mar 13, 2018

No description provided.

@wpt-pr-bot wpt-pr-bot requested a review from aliams Mar 13, 2018


Unfortunately, most of the tests are **manual** and require drag-and-drop of test data.
They can be run via [w3c-test.org](http://w3c-test.org/entries-api/), but a local
clone of the repo for access to the `entries-api/support` files.

This comment has been minimized.

Copy link
@aliams

aliams Mar 13, 2018

Contributor

...local clone of the repo is required for access...?

@aliams

aliams approved these changes Mar 13, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 13, 2018

Build PASSED

Started: 2018-03-14 17:19:06
Finished: 2018-03-14 17:26:55

View more information about this build on:

@inexorabletash inexorabletash requested a review from mkruisselbrink Mar 13, 2018


Unfortunately, most of the tests are **manual** and require drag-and-drop of test data.
They can be run via [w3c-test.org](http://w3c-test.org/entries-api/), but a local
clone of the repo is required for access to the `entries-api/support` files.

This comment has been minimized.

Copy link
@mkruisselbrink

mkruisselbrink Mar 13, 2018

Contributor

It wasn't obvious to me until looking at the entries-api/support directory why you would need access to those files. Maybe explicitly mention that the test data it is talking about lives in that directory?

@inexorabletash

This comment has been minimized.

Copy link
Contributor Author

inexorabletash commented Mar 14, 2018

Thanks - how's this rewording?

@mkruisselbrink
Copy link
Contributor

mkruisselbrink left a comment

thanks!

@inexorabletash inexorabletash merged commit 77530f2 into master Mar 14, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@inexorabletash inexorabletash deleted the entries-api-readme branch Mar 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.