Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add and correct CSSOM spec references #10005

Merged
merged 2 commits into from Mar 14, 2018

Conversation

Projects
None yet
5 participants
@csnardi
Copy link
Member

csnardi commented Mar 13, 2018

Many CSSOM tests were missing spec references or had incorrect ones; add/update these references.

Also move a CSSOM View test to the cssom-view directory.


This change is Reviewable

csnardi added some commits Mar 13, 2018

Add and correct CSSOM spec references
Many CSSOM tests were missing spec references or had incorrect ones; add/update these references.
Move GetBoundingRect.html
getBoundingClientRec is defined in CSSOM View, not CSSOM.
@@ -1,5 +1,6 @@
<!DOCTYPE html>
<title>Historical features</title>
<link rel="help" href="https://drafts.csswg.org/cssom/#changes-from-5-december-2013">

This comment has been minimized.

Copy link
@csnardi

csnardi Mar 13, 2018

Author Member

This is the best link I could find; it was removed from the spec and so this test is making sure that the features are not present.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 13, 2018

Build PASSED

Started: 2018-03-13 22:46:36
Finished: 2018-03-13 22:52:16

View more information about this build on:

@Ms2ger

Ms2ger approved these changes Mar 14, 2018

@Ms2ger Ms2ger merged commit b52a190 into web-platform-tests:master Mar 14, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@foolip

This comment has been minimized.

Copy link
Contributor

foolip commented Mar 23, 2018

FYI, the master Travis job https://travis-ci.org/w3c/web-platform-tests/jobs/353223566 failed after this was merged so no merge_pr_10005 tag was created, but I'll add it manually for commit b52a190.

@csnardi csnardi deleted the csnardi:cssom-spec-links branch Apr 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.