Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite CSSOM index tests #10014

Merged
merged 2 commits into from Apr 3, 2018

Conversation

Projects
None yet
5 participants
@csnardi
Copy link
Member

csnardi commented Mar 13, 2018

index-001.html and index-002.html had nondescript names, and index-002.html used generate_tests. Merge index-001.html into shorthand-serialization.html, and create shorthand-values.html from index-002.html.

Builds off the work of #5331.


This change is Reviewable

Rewrite CSSOM index tests
index-001.html and index-002.html had nondescript names, and index-002.html used generate_tests. Merge index-001.html into shorthand-serialization.html, and create shorthand-values.html from index-002.html.

Builds off the work of #5331.
'border: 1px; border-top-color: red;': 'border-width: 1px; border-top-color: red;',
'border: solid; border-style: dotted': 'border: dotted;',
'border-width: 1px;': 'border-width: 1px;',
'overflow-x: scroll; overflow-y: hidden;': 'overflow: scroll hidden;',

This comment has been minimized.

Copy link
@csnardi

csnardi Mar 13, 2018

Author Member

This disagrees with https://github.com/w3c/web-platform-tests/blob/master/css/cssom/overflow-serialization.html but I can't find a reference in the spec for the correct behavior.

This comment has been minimized.

Copy link
@gsnedders

gsnedders Mar 13, 2018

Contributor

Can you file a bug on CSSOM for that?

This comment has been minimized.

Copy link
@csnardi

csnardi Mar 13, 2018

Author Member

Ah, it looks like w3c/csswg-drafts#1100 covered this, since overflow only takes one parameter. As such, this test is in the wrong; it looks like this is covered by https://drafts.csswg.org/cssom/#serialize-a-css-declaration-block (although the language is slightly unclear).

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 13, 2018

Build PASSED

Started: 2018-03-29 22:23:08
Finished: 2018-03-29 22:29:53

View more information about this build on:

@FremyCompany
Copy link
Contributor

FremyCompany left a comment

LGTM

@csnardi

This comment has been minimized.

Copy link
Member Author

csnardi commented Apr 3, 2018

@FremyCompany Can you merge this (I don't have the ability to) and also close #5331 since it's no longer relevant?

@FremyCompany FremyCompany merged commit 09329e8 into web-platform-tests:master Apr 3, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@FremyCompany

This comment has been minimized.

Copy link
Contributor

FremyCompany commented Apr 3, 2018

Done

@csnardi csnardi deleted the csnardi:cssom-index-tests branch Apr 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.