Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sensor referenceFrame/frequency TypeError tests #10024

Merged
merged 2 commits into from Mar 15, 2018

Conversation

Projects
None yet
4 participants
@kaixinjxq
Copy link
Contributor

kaixinjxq commented Mar 14, 2018

No description provided.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 14, 2018

Build PASSED

Started: 2018-03-15 02:52:52
Finished: 2018-03-15 03:00:38

View more information about this build on:

() => { new sensorType({frequency: freq}) },
`when freq is ${freq}`);
});
}, `${sensorType.name}: throw 'TypeError' if frequency is an incorrect value type`);

This comment has been minimized.

Copy link
@Honry

Honry Mar 15, 2018

Contributor

The test name is not quite appropriate, as Infinity is also typeof number. So I think we can just describe it as "throw 'TypeError' if frequency is invalid"

This comment has been minimized.

Copy link
@kaixinjxq

kaixinjxq Mar 15, 2018

Author Contributor

Thx @Honry, updated.

@Honry

Honry approved these changes Mar 15, 2018

Copy link
Contributor

Honry left a comment

Thanks, LGTM

@Honry Honry merged commit 7c4bc54 into web-platform-tests:master Mar 15, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kaixinjxq kaixinjxq deleted the kaixinjxq:sensor_option branch Mar 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.