Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

idlharness.js: Distinguish instance toJSON is being executed against when it's inherited #10029

Conversation

5 participants
@lukebjerring
Copy link
Contributor

lukebjerring commented Mar 14, 2018

The specific 'bug' that I am attempting to fix is outlined in #9787 - also fixes #7492

I am unsure why changing [Default] toJSON(); to [Default] object toJSON(); suddenly results in the new error:

3 duplicate test names: "Test default toJSON operation of DOMPointReadOnly", "Test default toJSON 
operation of DOMRectReadOnly", "Test default toJSON operation of DOMMatrixReadOnly"

I have clarified that the duplication occurs from running the test on both DOMMatrix and DOMMatrixReadOnly, where DOMMatrix : DOMMatrixReadOnly.
this.name is DOMMatrixReadOnly in both cases, in spite of the idlArray object instance being DOMMatrix.


This change is Reviewable

@wpt-pr-bot wpt-pr-bot added the infra label Mar 14, 2018

@wpt-pr-bot wpt-pr-bot requested review from ayg, gsnedders and jgraham Mar 14, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 14, 2018

Build PASSED

Started: 2018-03-22 14:31:59
Finished: 2018-03-22 14:38:52

View more information about this build on:

@gsnedders gsnedders requested a review from tobie Mar 15, 2018

@lukebjerring

This comment has been minimized.

Copy link
Contributor Author

lukebjerring commented Mar 19, 2018

@tobie - any idea when you'll be able to take a look?

@tobie

This comment has been minimized.

Copy link
Contributor

tobie commented Mar 19, 2018

LGTM. I think this also fixes #7492. Could you check?

@tobie

This comment has been minimized.

Copy link
Contributor

tobie commented Mar 19, 2018

Note, you'll have to fix the test suite accordingly.

@lukebjerring

This comment has been minimized.

Copy link
Contributor Author

lukebjerring commented Mar 22, 2018

@tobie - Correct, fixes #7492, will add that to the desc. This is now good to go.

@foolip

foolip approved these changes Mar 23, 2018

@lukebjerring lukebjerring merged commit 4578f69 into web-platform-tests:master Mar 23, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@lukebjerring lukebjerring deleted the lukebjerring:idlharness-interface-by-instance branch Mar 23, 2018

@lukebjerring lukebjerring added this to idlharness.js blockers/issues in Auto-import IDL files Jun 18, 2018

@foolip foolip moved this from idlharness.js blockers/issues to Done in Auto-import IDL files Aug 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.