Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gecko Bug 1438210] Make slot assignment sound with layout after bug 1409975. #10039

Merged
merged 1 commit into from Mar 15, 2018

Conversation

Projects
None yet
3 participants
@moz-wptsync-bot
Copy link
Collaborator

moz-wptsync-bot commented Mar 14, 2018

Summary:
Before that bug, we carefully told layout about all distribution changes before
they happened, so layout could cleanup frames and styles synchronously properly
(since otherwise there's no way afterwards to figure out what the tree shape
was).

That bug made it not do it correctly, causing this.

I obviously need to write a bunch of tests for this...

Reviewers: smaug

Bug #: 1438210

Differential Revision: https://phabricator.services.mozilla.com/D724
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1438210
gecko-commit: 6b06d04460074d2d4f81ada49ff36a57ccbf5ff7
gecko-integration-branch: mozilla-inbound
gecko-reviewers: smaug

Make slot assignment sound with layout after bug 1409975.
Summary:
Before that bug, we carefully told layout about all distribution changes before
they happened, so layout could cleanup frames and styles synchronously properly
(since otherwise there's no way afterwards to figure out what the tree shape
was).

That bug made it not do it correctly, causing this.

I obviously need to write a bunch of tests for this...

Reviewers: smaug

Bug #: 1438210

Differential Revision: https://phabricator.services.mozilla.com/D724
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1438210
gecko-commit: 6b06d04460074d2d4f81ada49ff36a57ccbf5ff7
gecko-integration-branch: mozilla-inbound
gecko-reviewers: smaug
@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 14, 2018

Build PASSED

Started: 2018-03-14 18:42:00
Finished: 2018-03-14 18:53:09

View more information about this build on:

@moz-wptsync-bot moz-wptsync-bot merged commit 2eef29f into master Mar 15, 2018

1 of 2 checks passed

upstream/gecko Landed on mozilla-central
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@moz-wptsync-bot moz-wptsync-bot deleted the gecko/1438210 branch Mar 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.