Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stops using wrappedJSObject in marionette executor #10041

Merged
merged 5 commits into from Mar 20, 2018

Conversation

Projects
None yet
4 participants
@kritisingh1
Copy link
Member

kritisingh1 commented Mar 14, 2018

Closes #10035

@wpt-pr-bot wpt-pr-bot added the infra label Mar 14, 2018

@wpt-pr-bot wpt-pr-bot requested review from gsnedders and jgraham Mar 14, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 14, 2018

Build PASSED

Started: 2018-03-15 19:07:59
Finished: 2018-03-15 19:24:01

View more information about this build on:

@jgraham

This comment has been minimized.

Copy link
Contributor

jgraham commented Mar 15, 2018

Ah, sorry I didn't explain this very well. I think it should be possible to replace window.wrappedJSObject with just window, although we may need to change the way we call marionette.new_session if it doesn't work initially.

@wpt-pr-bot

This comment has been minimized.

Copy link
Collaborator

wpt-pr-bot commented Mar 15, 2018

There are no owners for this pull request. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you!

@kritisingh1 kritisingh1 force-pushed the kritisingh1:wrappedJSObject branch from 7909395 to ea1a9c7 Mar 15, 2018

@kritisingh1

This comment has been minimized.

Copy link
Member Author

kritisingh1 commented Mar 15, 2018

@jgraham I have made the changes. Is there anything else that needs to be done?

@jgraham

This comment has been minimized.

Copy link
Contributor

jgraham commented Mar 15, 2018

Yes, there are some other places that use this including tools/wptrunner/wptrunner/executors/testharness_marionette.js

@kritisingh1

This comment has been minimized.

Copy link
Member Author

kritisingh1 commented Mar 15, 2018

@jgraham Please review. Thanks

@jgraham
Copy link
Contributor

jgraham left a comment

This looks great, thanks!

@jgraham jgraham merged commit e04e71f into web-platform-tests:master Mar 20, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.