Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve wpt testing on OffscreenCanvas convertToBlob #10051

Merged
merged 1 commit into from Mar 19, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Mar 15, 2018

Same as canvas.toBlob(), the OffscreenCanvas.convertToBlob() are running on
idle tasks by default. When idle tasks do not begin for a long time, they force
encoding on the current thread. As idle tasks are not enabled on layout tests
unless "--enable-threaded-compositing" flag is turned on, we therefore do both
virtual and non-virtual tests to ensure complete test coverage of both
execution paths--idle-task mode and force-encoding mode. The non-virtual tests
need to be marked as [Slow] as the CanvasAsyncBlobCreator is waiting for the
idle tasks for a threshold time before switching to force-encoding mode.

Bug: 817091
Change-Id: I2c7da9e27ee2d24e1a5e6ee1c36597b46f052aca
Reviewed-on: https://chromium-review.googlesource.com/964395
Reviewed-by: Justin Novosad junov@chromium.org
Commit-Queue: Olivia Lai xlai@chromium.org
Cr-Commit-Position: refs/heads/master@{#544036}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 15, 2018

Build PASSED

Started: 2018-03-19 15:33:51
Finished: 2018-03-19 15:39:27

View more information about this build on:

Improve wpt testing on OffscreenCanvas convertToBlob
Same as canvas.toBlob(), the OffscreenCanvas.convertToBlob() are running on
idle tasks by default. When idle tasks do not begin for a long time, they force
encoding on the current thread. As idle tasks are not enabled on layout tests
unless "--enable-threaded-compositing" flag is turned on, we therefore do both
virtual and non-virtual tests to ensure complete test coverage of both
execution paths--idle-task mode and force-encoding mode. The non-virtual tests
need to be marked as [Slow] as the CanvasAsyncBlobCreator is waiting for the
idle tasks for a threshold time before switching to force-encoding mode.

Bug: 817091
Change-Id: I2c7da9e27ee2d24e1a5e6ee1c36597b46f052aca
Reviewed-on: https://chromium-review.googlesource.com/964395
Reviewed-by: Justin Novosad <junov@chromium.org>
Commit-Queue: Olivia Lai <xlai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544036}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-964395 branch from 08f2041 to 341f3f5 Mar 19, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 919015d into master Mar 19, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-964395 branch Mar 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.