Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tentative test for what ".." on documentElement returns #10055

Merged

Conversation

Projects
None yet
4 participants
@gsnedders
Copy link
Contributor

gsnedders commented Mar 15, 2018

As far as I can tell, from both DOM Level 3 XPath and XPath 1.0, this is undefined. As far as the XPath data model is concerned, documentElement can have no parent, and DOM Level 3 XPath doesn't address this.

However, at least Chrome/Edge/Firefox/Safari all pass this test, so it seems like something we should test.

@wpt-pr-bot wpt-pr-bot requested review from deniak and zqzhang Mar 15, 2018

@gsnedders gsnedders requested a review from Ms2ger Mar 15, 2018

@gsnedders gsnedders force-pushed the gsnedders:xpath-documentElement-parent branch from d87a8ac to 0c63aee Mar 15, 2018

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 15, 2018

Build PASSED

Started: 2018-03-15 18:45:41
Finished: 2018-03-15 18:54:32

View more information about this build on:

@Ms2ger

Ms2ger approved these changes Mar 16, 2018

Copy link
Contributor

Ms2ger left a comment

@gsnedders

This comment has been minimized.

Copy link
Contributor Author

gsnedders commented Mar 16, 2018

@Ms2ger writing that up makes me realise we need tests for root adjacent comments, PIs, and doctypes (esp. doctypes, given XPath has no notion of them).

@gsnedders gsnedders merged commit 5033883 into web-platform-tests:master Mar 16, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gsnedders gsnedders deleted the gsnedders:xpath-documentElement-parent branch Mar 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.