Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement tail processing for AudioNodes #10056

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Mar 15, 2018

Enable tail processing by calling the necessary routines. A
continuation of https://chromium-review.googlesource.com/c/chromium/src/+/949762
where tail processing is actually running.

Keep nodes alive when there are no input connections so that the node
has time to flush out any internal memory. When the output of the node
is going to be disabled (because there are no inputs), place the node
on a list, without disabling the output.

The list is processed every rendering quantum to see if the tail time
of node has passed. If the tail time has not passed, nothing is done;
otherwise, the output is disabled, and the node is removed from the
list. This allows the node to be collected, if possible.

Bug:357843, 731518
Test:AudioNode/tail-processing.html,DynamicsCompressor/dynamicscompressor-clear-internal-state.html

Change-Id: I5ba37015787fbbb2342eacb57b4851b99a36b3c5
Reviewed-on: https://chromium-review.googlesource.com/661165
WPT-Export-Revision: c9023dd68b23c2f8a908cc32fbbb0305056af94b

Implement tail processing for AudioNodes
Enable tail processing by calling the necessary routines.  A
continuation of https://chromium-review.googlesource.com/c/chromium/src/+/949762
where tail processing is actually running.

Keep nodes alive when there are no input connections so that the node
has time to flush out any internal memory. When the output of the node
is going to be disabled (because there are no inputs), place the node
on a list, without disabling the output.

The list is processed every rendering quantum to see if the tail time
of node has passed.  If the tail time has not passed, nothing is done;
otherwise, the output is disabled, and the node is removed from the
list.  This allows the node to be collected, if possible.

Bug:357843, 731518
Test:AudioNode/tail-processing.html,DynamicsCompressor/dynamicscompressor-clear-internal-state.html

Change-Id: I5ba37015787fbbb2342eacb57b4851b99a36b3c5
@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 15, 2018

Build PASSED

Started: 2018-03-15 18:52:33
Finished: 2018-03-15 19:01:56

View more information about this build on:

@Hexcles

This comment has been minimized.

Copy link
Member

Hexcles commented Jun 22, 2018

No exportable changes.

@Hexcles Hexcles closed this Jun 22, 2018

@Hexcles Hexcles deleted the chromium-export-cl-661165 branch Jun 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.