Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[shapes] Remove shape-outside avoiding behaviour for new-FCs/replaced. #10057

Merged
merged 1 commit into from Mar 16, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Mar 15, 2018

See intent: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/pfDg-VAeKWs

This makes new formatting contexts behave exactly like floats would
when they are positioned. I.e. they don't look at the shape-outside
of the float, and instead as positioned for their margin box.

I've added a .tentative test as per the intent.

This will allow us to have a (relatively) simple implementation of
css-shapes in LayoutNG as we only have to consider the shape area for
line-boxes. \o/

Bug: 820520
Change-Id: Ib07600a291eb4838675a9a1068c5fc16cac0633f
Reviewed-on: https://chromium-review.googlesource.com/739961
Commit-Queue: Ian Kilpatrick ikilpatrick@chromium.org
Reviewed-by: Morten Stenshorne mstensho@chromium.org
Cr-Commit-Position: refs/heads/master@{#543813}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 15, 2018

Build PASSED

Started: 2018-03-16 20:51:49
Finished: 2018-03-16 20:56:16

View more information about this build on:

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-739961 branch from 0b8ccde to bbd23a1 Mar 16, 2018

[shapes] Remove shape-outside avoiding behaviour for new-FCs/replaced.
See intent: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/pfDg-VAeKWs

This makes new formatting contexts behave exactly like floats would
when they are positioned. I.e. they don't look at the shape-outside
of the float, and instead as positioned for their margin box.

I've added a .tentative test as per the intent.

This will allow us to have a (relatively) simple implementation of
css-shapes in LayoutNG as we only have to consider the shape area for
line-boxes. \o/

Bug: 820520
Change-Id: Ib07600a291eb4838675a9a1068c5fc16cac0633f
Reviewed-on: https://chromium-review.googlesource.com/739961
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543813}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-739961 branch from bbd23a1 to ba2d360 Mar 16, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 53ea2c3 into master Mar 16, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-739961 branch Mar 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.